Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Upgrade Extension and HandshakeMessage types to QD parsers #218

Open
10 of 15 tasks
ad-l opened this issue Dec 20, 2018 · 1 comment
Open
10 of 15 tasks

Upgrade Extension and HandshakeMessage types to QD parsers #218

ad-l opened this issue Dec 20, 2018 · 1 comment

Comments

@ad-l
Copy link
Contributor

ad-l commented Dec 20, 2018

In preparation of the new HandshakeLog interface, we should finish porting the types of message contents to the QD-generated ones.

  • Split the extension into separate types for CH, SH, EE, CR, C, NST. Remove ext_msg index.
  • Remove sum types from the leaf types (psk, protocol_version, keyShare, etc)
  • Upgrade psk to PreSharedKeyClientExtension/PreSharedKeyServerExtension
  • Upgrade protocol_version to SupportedVersions/ProtocolVersion
  • Upgrade list serverName to ServerNameList/OneServerName
  • Upgrade keyShare to KeyShareClientHello/KeyShareEntry
  • Upgrade earlyDataIndication
  • Upgrade list point_format to ECPointFormatList
  • Upgrade list CommonDH.namedGroup to NamedGroupList
  • Upgrade signatureSchemeList to SignatureSchemeList

Once this is done, we can update the internal extension parsers in HandshakeMessage to the generated ones. The next step is to upgrade HandshakeMessage itself:

  • Split handshakeType into handshakeType, handshakeType12, handshakeType13 and hs_msg into handshakeMessage, handshakeMessage12, handshakeMessage13
  • Split the Handshake.recv_fragment state machine more cleanly to operate on separate message types
  • Upgrade ClientHello, ServerHello, and HelloRetryRequest
  • Upgrade TLS 1.3 messages
  • Upgrade TLS <1.3 messages
@ad-l
Copy link
Contributor Author

ad-l commented Jan 23, 2019

The first part is complete in adl_extensions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant