One bad config is not ignored

[ghost]

Use STORAGE_DRIVERS=overlay2 instead of correct STORAGE_DRIVER will result in some unexpected error messages.

# docker-storage-setup
ERROR: Invalid storage driver: devicemapper.

[rhvgoyal]

Are you testing the latest code?

[rhvgoyal]

I can't reproduce it.

[rhvgoyal]

Oh you specified extra S, I can see it.

[rhvgoyal]

Ok, this overrides that internal variable STORAG_DRIVERS and that's the problem.

[rhvgoyal]

@rhatdan may be we should source the external files first and then define internal global variables to make sure users can't intentionally/accidentally override container-storage-setup gloabal variables?

[rhatdan]

#217

[rhvgoyal]

@rhatdan I am playing with another patch where I want to initialize global variables after sourcing config file. That way all the globals will be protected.

[rhatdan]

We can also do that, but it could get confusing. We have globals that can be overridden, as well.

[rhvgoyal]

I think I have taken care of that in my patch. Have a look.