Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M109, M190 Do not meet Marlin specs #2126

Closed
GWdd opened this issue Aug 20, 2019 · 3 comments
Closed

M109, M190 Do not meet Marlin specs #2126

GWdd opened this issue Aug 20, 2019 · 3 comments

Comments

@GWdd
Copy link

GWdd commented Aug 20, 2019

M109 / M190 - according to Marlin, should have two argument options:

  • R - set temperature and wait for temp to reach absolute setpoint (wait for cooling or heating).
  • S - set temperature and wait for temp to be at or above setpoint-

Prusa firmware will wait for heating or cololing when M109 Sxxx is used. Which does not meet the Marlin spec.

see: http://marlinfw.org/docs/gcode/M109.html

There are cases where the S option as designed by the Marlin team are useful.

@haarp
Copy link

haarp commented Aug 22, 2019

Duplicate of #1474. I've opened a trivial PR that'll fix this in #2060, but got no reaction yet.

@github-actions
Copy link

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This issue has been closed due to lack of recent activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants