You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Existing os.subprocess.call invocations in ConsensusCruncher.py create a string and then split it on spaces. This could be dangerous if any of the strings being passed in to the .format() call contain spaces. This could be mitigated by converting lines like this:
call("{} index {}/{}.sorted.bam".format(args.samtools, bam_dir, filename).split(' '))
Describe the bug
os.system()
presents security vulnerabilities. The Python docs indicate that using thesubprocess
module is preferred.To Reproduce
See 5 instances of
os.system()
in ConsensusCruncher.pyAdditional considerations
Existing
os.subprocess.call
invocations in ConsensusCruncher.py create a string and then split it on spaces. This could be dangerous if any of the strings being passed in to the.format()
call contain spaces. This could be mitigated by converting lines like this:To:
The text was updated successfully, but these errors were encountered: