Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module's NSVCA cannot be used as uniqueness constraint #3241

Closed
ipanova opened this issue Sep 4, 2023 · 0 comments · Fixed by #3242
Closed

Module's NSVCA cannot be used as uniqueness constraint #3241

ipanova opened this issue Sep 4, 2023 · 0 comments · Fixed by #3242
Assignees
@ipanova
Labels
Issue Satellite

Comments

@ipanova
Copy link
Member

ipanova commented Sep 4, 2023

Version
all

Describe the bug
Description of problem:
If synchronizing Oracle Linux 9 AppStream (after RHEL9 AppStream synced, or viceversa) Pulp will show just one ruby module based on what todays' uniqueness allows.

RHEL9 released this snippet for ruby 3.1 module stream:

document: modulemd
version: 2
data:
name: ruby
stream: "3.1"
version: 9010020220623124214
context: 9
static_context: true
arch: x86_64
..
artifacts:
rpms:
- ruby-0:3.1.2-141.module+el9.1.0+15737+76195479.i686
- ruby-0:3.1.2-141.module+el9.1.0+15737+76195479.src
- ruby-0:3.1.2-141.module+el9.1.0+15737+76195479.x86_64
- ruby-bundled-gems-0:3.1.2-141.module+el9.1.0+15737+76195479.i686
..

Few months later on, Oracle Linux 9 AppStream was released, with ruby 3.1 module stream:

document: modulemd
version: 2
data:
name: ruby
stream: "3.1"
version: 9010020220623124214
context: 9
static_context: true
arch: x86_64
..
artifacts:
rpms:
- ruby-0:3.1.2-141.module+el9.1.0+20815+286161bd.i686
- ruby-0:3.1.2-141.module+el9.1.0+20815+286161bd.x86_64
- ruby-bundled-gems-0:3.1.2-141.module+el9.1.0+20815+286161bd.i686

To Reproduce
Sync these 2 repos.

Expected behavior
Observe that pulp has just one ruby module with unique NSVCA instead of 2 modules with same NSVCA but different snippet content.

Additional context
https://bugzilla.redhat.com/show_bug.cgi?id=2232500
@ipanova ipanova self-assigned this Sep 4, 2023
ipanova added a commit to ipanova/pulp_rpm that referenced this issue Sep 4, 2023
@ipanova
Allow two modules with same NSVCA but different snippet content.
cabd8ae 
closes pulp#3241

It no longer holds true to rely on NSVCA module's uniqueness, add the
hash of the document snippet to it.
@pulpbot pulpbot moved this to In Progress in RH Pulp Kanban board Sep 4, 2023
@ipanova ipanova mentioned this issue Sep 4, 2023
Merged
@pulpbot pulpbot moved this from In Progress to Needs review in RH Pulp Kanban board Sep 4, 2023
ipanova added a commit to ipanova/pulp_rpm that referenced this issue Sep 4, 2023
@ipanova
Allow two modules with same NSVCA but different snippet content.
b92efb8 
closes pulp#3241

It no longer holds true to rely on NSVCA module's uniqueness, add the
hash of the document snippet to it.
ipanova added a commit to ipanova/pulp_rpm that referenced this issue Sep 4, 2023
@ipanova
Allow two modules with same NSVCA but different snippet content.
20f77e4 
closes pulp#3241

It no longer holds true to rely on NSVCA module's uniqueness, add the
hash of the document snippet to it.
ipanova added a commit to ipanova/pulp_rpm that referenced this issue Sep 6, 2023
@ipanova
Allow two modules with same NSVCA but different snippet content.
c7aee9d 
closes pulp#3241

It no longer holds true to rely on NSVCA module's uniqueness, add the
hash of the document snippet to it.
dralley pushed a commit that referenced this issue Sep 8, 2023
@ipanova @dralley
Allow two modules with same NSVCA but different snippet content.
7a66a3e 
closes #3241

It no longer holds true to rely on NSVCA module's uniqueness, add the
hash of the document snippet to it.
@pulpbot pulpbot moved this from Needs review to Done in RH Pulp Kanban board Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipanova ipanova

Labels
Issue Satellite
Projects
No open projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow two modules with same NSVCA but different snippet content. ipanova/pulp_rpm
3 participants
@dralley @ipanova @ggainey