Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status and support for 1.1 spec changes? #4

Open
tmpfs opened this issue Aug 14, 2020 · 1 comment
Open

Status and support for 1.1 spec changes? #4

tmpfs opened this issue Aug 14, 2020 · 1 comment

Comments

@tmpfs
Copy link

tmpfs commented Aug 14, 2020

Hi @pwoolcoc , I am researching using this crate for a project and I noticed there haven't been any commits for a while and I would like support for version 1.1 of the specification. Specifically, I need the new authors and language fields.

So my questions are: 1) is this crate still being maintained? 2) would you accept a PR that updates for the 1.1 spec changes?

Happy to fork if you are no longer interested in maintaining this crate but of course would prefer to contribute back if possible.

Thanks!

@tmpfs
Copy link
Author

tmpfs commented Aug 16, 2020

So I have submitted this PR which is an easy upgrade to version 1.1 of the spec and I think you could merge that.

I also wanted to simplify various aspects of the code and update to use some of the more recent libraries which can be found in the develop branch, it includes:

  • Update to prefer thiserror
  • Update to use serde_with::skip_serializing_none
  • Remove Content enum so that all the custom serde logic could be removed
  • Removed the builder as I don't need it and it seems extraneous
  • Update version string to 1.1

I imagine you don't want any of these big sweeping changes which is why I only submitted the small spec fixes but they are there if you do!

Thanks for the library 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant