Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: You can now drop NPY_MAXARGS starting with NPY_2_3_API_VERSION #502

Open
seberg opened this issue Jan 7, 2025 · 0 comments
Open

ENH: You can now drop NPY_MAXARGS starting with NPY_2_3_API_VERSION #502

seberg opened this issue Jan 7, 2025 · 0 comments

Comments

@seberg
Copy link
Contributor

seberg commented Jan 7, 2025

As promised, you can now [1] do a runtime check for PyArray_RUNTIME_VERSION >= NPY_2_3_API_VERSION. If this is the case, NPY_MAXARGS is irrelevant (integer number of operands supported).
NumPy always raised an error for you on older versions, but I suppose it may make sense to keep the check to make that error clearer.

Of course, NE_MAXARGS is still used for numexpr internal stack allocations. That could be arbitrarily bumped or refactored away now.

[1] Well, may want to wait a few days for the next nightly (the version macro is also slightly off).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant