Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on asynccontextgenerator #18

Open
thearchitector opened this issue Aug 10, 2023 · 4 comments
Open

Dependency on asynccontextgenerator #18

thearchitector opened this issue Aug 10, 2023 · 4 comments

Comments

@thearchitector
Copy link

thearchitector commented Aug 10, 2023

@asynccontextgenerator is available in the standard contextlib module from Python 3.7+, and available via package for 3.5 and 3.6.

This uses the package, but its not listed as a dependency. It would nice for it to be listed as one for specifically 3.5/6, via the python_version meta, with a corresponding check in the actual code to just use the std lib one if its available instead.

@thearchitector thearchitector changed the title Dependency on asynccontextgenerators Dependency on asynccontextgenerator Aug 10, 2023
@Zac-HD
Copy link
Member

Zac-HD commented Oct 26, 2023

from async_generator import asynccontextmanager

I'd prefer to replace this with the contextlib version, and explicitly drop support for end-of-life versions of Python via python_requires=">=3.8". @jakkdl?

@jakkdl
Copy link
Member

jakkdl commented Oct 26, 2023

on it!

@jakkdl
Copy link
Member

jakkdl commented Oct 26, 2023

oh boi, the test infra is horribly outdated.

@jakkdl
Copy link
Member

jakkdl commented Feb 1, 2024

on it!

dropping this. Writing the PR is fairly trivial, so if anybody does use triopg and want to update it and/or do other maintaining I'd recommend they do it. I'm instead creating #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants