Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more classifier #492

Open
4 tasks
poig opened this issue Oct 18, 2022 · 6 comments
Open
4 tasks

Add more classifier #492

poig opened this issue Oct 18, 2022 · 6 comments
Labels
type: feature request 💡 New feature or request
Milestone

Comments

@poig
Copy link

poig commented Oct 18, 2022

What should we add?

we should include more classifiers:

Maybe we should add these also:

  • Quantum GaussianNB
  • Quantum DecisionTreeClassifier
@poig poig added the type: feature request 💡 New feature or request label Oct 18, 2022
@chin-jey
Copy link

There's this project implementing other quantum classification and regression methods : https://github.com/mspronesti/qlearnkit

@poig
Copy link
Author

poig commented Oct 21, 2022

Yeah, thanks for the share, it includes QKmeans, Qridge, QSVM K-NN, regression, dataset, encoding map, swaptest circuit, but it's not fit the latest qiskit version.

@chin-jey
Copy link

Why not ? It seems it does to me.

@poig
Copy link
Author

poig commented Oct 21, 2022

Why not ? It seems it does to me.

thanks, I just see that it fit with the sources code, but not the latest release version.

@adekusar-drl
Copy link
Collaborator

For example, quantum KNN requires either access to quantum memory to keep the states handy or re-creation of states every time when a distance is evaluated. Thus, the quantum version of the algorithm does not bring any advantages over the classical version. I can't say the above mentioned algorithms suffer from the same problem, they have to be studied and evaluated if they can bring value for this package. If you want to develop one of them, and possibly to contribute them, we can discuss in more details.

@edoaltamura
Copy link
Collaborator

Hi @poig @chin-jey, have there been recent developments on this discussion? Feel free to post a simple example here, as it might be useful for others. Once we've seen an implementation, we can evaluate together if it's worth turning it into a PR.

@edoaltamura edoaltamura added this to the v.0.9.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request 💡 New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants