-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other combinations for decomposition to rotation matrices #71
Comments
Possible combinations (screenshot from page 6). If instead of using |
Is there a way to define only a few of them explicitly and then use unitary transformation to get the rest of them? Although unitary transformation may introduce some minor numerical error, having 12 distinct implementations seems very hard to maintain and debug. |
Yeah, I have been working over the calculations. I am trying to figure out which ones need to be specified explicitly or if all can be calculated via zyz.
Thought the same after I made my previous comment. If I use these for ABC decomposition as well then there will be 24 private functions in total !! It's better to do the calculations and create a dictionary of the angles for each combination. |
Hey @purva-thakre @BoxiLi , I'm interested in contributing to this package and doing a project for GSoC '22 We can probably create a method _angles_for_rotation that defaults to output the angles of a zyz rotation and make the other ones available as alternative decomposition if requested by the user. It shouldn't be too difficult to do the calculations from that paper. |
Hi @Buffoni ! I have worked on a working form of this. Haven't had the chance to push it yet because first I need to fix a phase error in the existing |
Ok, I'll see how I can contribute to other issues or open a new one, thanks! |
In the single qubit gate decomposition module, if the gate is supposed to decomposed to product of rotation matrices then two possibilities are
ZYZ
andZXZ
.Map the angles from
ZYZ
to other combinations -YXY, YZY, XZX, XYX
.The text was updated successfully, but these errors were encountered: