Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Improvements #13

Open
pmenczel opened this issue Apr 24, 2024 · 4 comments
Open

Documentation Improvements #13

pmenczel opened this issue Apr 24, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@pmenczel
Copy link
Member

  1. The explanation of the GRAPE and CRAB methods in the users' guide is very detailed, but the explanation of GOAT is very brief and JOPT is still missing there. Eventually, it might be nice to have explanations for all methods at a similar level of detail.
  2. Currently, the search function in https://qutip-qoc.readthedocs.io/en/latest/ seems to be broken.
  3. It would be good to have example notebooks and link to them in the documentation and from the github readme page.

(These are issues that I believe could be tackled after the first proper release of qutip-qoc.)

@BoxiLi
Copy link
Member

BoxiLi commented Nov 13, 2024

It would be nice to revisit the documentation at some point. The code in the doc seems wrong as the Hamiltonian is defined as

# continuous control
control = [[qt.sigmax(), lambda t, p: p[0] * t + p[1]],
           [qt.sigmay(), lambda t, q: p[0] * t + p[1]]]

H = [drift, control]

without providing a gradient while the GOAD algorithm is used:

  algorithm_kwargs={
    "fid_err_targ": 0.1,
    "alg": "GOAT",
  },

This gives an error on my machine.

@rochisha000
Copy link

@BoxiLi @flowerthrower I came across this issue as well. What is the fix for this? I'm trying to learn qutip-qoc

@BoxiLi
Copy link
Member

BoxiLi commented Nov 15, 2024

Maybe for now you can check the test code in https://github.com/qutip/qutip-qoc/blob/main/tests/test_fidelity.py.

@flowerthrower
Copy link
Collaborator

You can also have a look at the examples in this PR: qutip/qutip-tutorials#104

@flowerthrower flowerthrower added the documentation Improvements or additions to documentation label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants