Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch endpoint for attachment metadata #27 #95

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rowan04
Copy link
Member

@rowan04 rowan04 commented Jan 16, 2025

Description

TODO: tests

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

Resolves #27

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Project coverage is 96.37%. Comparing base (d51376a) to head (4c3d0c6).

Files with missing lines Patch % Lines
object_storage_api/repositories/attachment.py 10.00% 9 Missing ⚠️
object_storage_api/services/attachment.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #95      +/-   ##
===========================================
- Coverage    99.28%   96.37%   -2.92%     
===========================================
  Files           19       19              
  Lines          422      441      +19     
===========================================
+ Hits           419      425       +6     
- Misses           3       16      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an endpoint for editing attachment metadata
2 participants