Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double buffered bounce buffer #520

Open
madsbk opened this issue Oct 28, 2024 · 0 comments
Open

Double buffered bounce buffer #520

madsbk opened this issue Oct 28, 2024 · 0 comments
Labels
improvement Improves an existing functionality

Comments

@madsbk
Copy link
Member

madsbk commented Oct 28, 2024 •
edited
Loading

We should investigate the performance benefit of implementing double buffering when using bounce buffers in POSIX and Remote IO.

Additionally, we should unify the implementation of the bounce buffer in POSIX IO and in Remote IO.
@madsbk madsbk added the improvement Improves an existing functionality label Oct 28, 2024
@madsbk madsbk mentioned this issue Oct 28, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Oct 30, 2024
@madsbk
RemoteIO: use a pinned bounce buffer (#519)
b65eda3 
We use a bounce buffer to avoid many small memory copies to device. Libcurl has a maximum chunk size of 16kb (`CURL_MAX_WRITE_SIZE`) but chunks are often much smaller.

For now, the bounce buffer isn't double buffered, let's defer that to later: #520

Authors:
  - Mads R. B. Kristensen (https://github.com/madsbk)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)

URL: #519
@madsbk madsbk changed the title Double buffed bounce buffer Double buffered bounce buffer Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improves an existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@madsbk