-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn data:update unusable on dev mode #1460
Comments
Hey @rtorrente, thanks for the report! Blob store is quite recent addition to address npm API stability, and indeed, for external contributors it might be a bit cumbersome, since you need to have an access to our Vercel org to be able to generate that token. A separate thing is that But definitely, we should just fall back, and skip fill-out data, when token is not present, instead of throwing. |
Hey @Simek, Thanks for the feedback. |
You also won't be able to test new entries in that much detail on the PR unless deployment label is added manually, since we only deploy website on schedule, every 2 hours, due to API limits that are enforced on us via GitHub and NPM. We don't even deploy when your PR lands on So in you case, indeed, the I will create a PR fixing the blob access soon, and make the fallback to older data an optional (not required) part of the flow. |
Oh nice, I didn't know it was possible to run calculations only for specific packages ! I believe that the majority of PRs are currently performed blind. Which isn't a good thing, because the directory is supposed to be a source of truth. |
Hey,
Command
GITHUB_TOKEN=* yarn data:update
does not work because it need a vercel token.This blocks testing while a library is being added, forcing you to commit blindly without being able to test the result on the display.
I think doc is outdated in Readme and a vercel function was added since
The text was updated successfully, but these errors were encountered: