-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the title in the "current position" Locator returned by the navigator #35
Comments
Just adding my 2 cents: I'm not a fan of displaying a title when reading. I'm fine seeing it when I tap in the middle of a page on mobile, but otherwise I find this more annoying than useful. For a desktop app, there should always by a full screen mode that doesn't display a title IMO. |
Better, this title should be related to the ToC if it exists. The issue being that a spine item may correspond to N entries in the ToC, of different levels (e.g. chapter, sub-section ...) and a spine item may not have any corresponding entry in the ToC. Also, many books have to title on their spine items. @HadrienGardeur in the case of our end user app Thorium, the title of the current location is displayed at the will of the user, so no issue there. |
Not sure those cases are covered in
So, to be on the safe side, taking the liberty to list re books whose several spine items can be a fragment of a chapter because…
|
The current implementation populates |
Personally I don’t, as I know how difficult that can become once you account for the corner and edge cases. All I can say is that DOM’s But then, I don’t have any clue what would generally be expected i.e. outside of this e-production context. |
The title is currently the title of the publication.
It should be the title of the current spine item (https://github.com/readium/architecture/tree/master/locators).
The text was updated successfully, but these errors were encountered: