Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to kill the java process running (not stop, kill) #253

Closed
yellak opened this issue Nov 10, 2022 · 5 comments
Closed

A way to kill the java process running (not stop, kill) #253

yellak opened this issue Nov 10, 2022 · 5 comments

Comments

@yellak
Copy link

yellak commented Nov 10, 2022

Sometimes, when I try to stop, the terminal gives an error, the server is set to "stopped" but the java process is still running and I have to kill it outside vscode.

@robstryker
Copy link
Collaborator

Can you give a bit more detail?

What server are you trying to stop? What version? Different servers (tomcat vs wildfly vs other) behave differently.

@yellak
Copy link
Author

yellak commented Nov 11, 2022

tomcat-server-issue

I know that maybe there is a way to fix the error at trying to stop, but I just want a way to kill if I want.

@yellak
Copy link
Author

yellak commented Nov 11, 2022

Tomcat 7.0.27

@robstryker
Copy link
Collaborator

So there's a few issues here. First, in the UI, the 'terminate' action is only enabled when the server is starting, stopping, or unknown. I suppose it should still be enabled for stopped and started just in case someone wants to use it.

Once that is fixed, I'm not 100% sure whether the back end still maintains a reference to the process when it marks itself as stopped. It might, but it might not. I'd have to dig deeper to figure that out.

Either way, I can definitely fix the first part. Second part is a maybe.

robstryker added a commit to robstryker/vscode-rsp-ui that referenced this issue Dec 6, 2022
…often, even if it might fail

Signed-off-by: Rob Stryker <[email protected]>
robstryker added a commit to robstryker/vscode-rsp-ui that referenced this issue Dec 6, 2022
…often, even if it might fail

Signed-off-by: Rob Stryker <[email protected]>
robstryker added a commit to robstryker/vscode-rsp-ui that referenced this issue Dec 6, 2022
…often, even if it might fail

Signed-off-by: Rob Stryker <[email protected]>
robstryker added a commit to robstryker/vscode-rsp-ui that referenced this issue Dec 6, 2022
…often, even if it might fail

Signed-off-by: Rob Stryker <[email protected]>
robstryker added a commit to robstryker/vscode-rsp-ui that referenced this issue Dec 6, 2022
…often, even if it might fail

Signed-off-by: Rob Stryker <[email protected]>
@robstryker
Copy link
Collaborator

So I want to list some caveats here: the UI will no longer block the terminate action from showing up.

However, if the backend RSP has lost its reference to the server process somehow, it still won't be able to terminate. The terminate action may fail. I'll open up another issue on the rsp-community for that I guess.

redhat-developer/rsp-server-community#150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants