Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SystemMetricsProducer to spring autoconfiguration #20

Open
mairovichaa opened this issue Aug 1, 2022 · 0 comments
Open

Add SystemMetricsProducer to spring autoconfiguration #20

mairovichaa opened this issue Aug 1, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@mairovichaa
Copy link
Collaborator

SystemMetricsProducer isn't part of Spring autoconfiguration.

I suggest to add a possibility to turn on its autoconfiguration by means of application's properties.

For example,

# application.yml
...
management:
    metrics:
        mf:
            collect:
                system: true
...

In this case
org.springframework.boot.actuate.autoconfigure.metrics.JvmMetricsAutoConfiguration
and
org.springframework.boot.actuate.autoconfigure.metrics.SystemMetricsAutoConfiguration
should be excluded from autoconfiguration as they collect similar metrics.

@mairovichaa mairovichaa added the enhancement New feature or request label Aug 1, 2022
@devromik devromik added the good first issue Good for newcomers label Sep 16, 2022
@devromik devromik added this to the 3.0 milestone Sep 20, 2022
@devromik devromik modified the milestones: 3.0, 3.1 Dec 23, 2022
@devromik devromik modified the milestones: 3.1, 3.2 May 18, 2023
@devromik devromik modified the milestones: 3.2, 4.0 Jun 12, 2023
@devromik devromik modified the milestones: 4.0, 4.2 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants