Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting an empty set of labels for the allSlice() of a labeled metric in postConfigure #68

Open
devromik opened this issue Oct 22, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@devromik
Copy link
Collaborator

Currently, the following code would fail:

metricRegistry.timer(withName("service", "processing", "time"));

metricRegistry.postConfigure(metricWithName("service.processing.time"),
    modifying().timer(withTimer().labels(SERVICE)
        .allSlice().labels());

It is still possible to achieve this by defining a new slice with no labels, but this can be inconvenient. If we allow no labels in the total slice, we should forbid a total instance with the same name as allSlice to avoid name conflicts.

@devromik devromik added the enhancement New feature or request label Oct 22, 2024
@devromik devromik added this to the 4.2 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant