ADDX bug?

[rimwall]

Hi,

Firstly I just want to say a huge thankyou for creating M32R support in Ghidra. It's been very useful for a project I'm working on.

I'm not very familiar with Ghidra processor files, but I am wondering if there is a bug in the *.sinc file for the ADDX command. Often the decompiler produces output with a 'CARRY4' function. An example...

            if (uVar4 < 0x350) {
              uVar6 = (uint)RAM_SSM_msg_data_byte0_0x804c07;
              uVar7 = uVar6 * 0x40000000;
              uVar10 = uVar6 * -0x80000000;
              uVar1 = uVar10 + (uVar4 < 0x350);
              iVar9 = uVar6 * -0x80000000 + (uint)(byte)(CARRY4(uVar7,uVar7) | CARRY4(uVar10,uVar1))
              ;
              if ((byte)(CARRY4(uVar7,uVar7) | CARRY4(uVar10,uVar1)) == 1) goto LAB_0003dd54;
              (&RAM_SSM_rsp_byte0_fmt_0x804c96)[uVar3] = *(&PTR_DAT_0007cd78)[uVar4 & 0xffff];
            }

which comes from the following machine code / disassembly...

Just wondering how I can fix this, or interpret the decompiler output?

Thanks!

[GhidrAuto]

how did you get it in the processor file? I have added a few processors without a problem. I cannot get this one added though. it doesnt show up in the processors

[rimwall]

Hi, so long ago I can't remember. Looks like I made some changes to two of the files (attached). I am using Ghidra 10.1 if that's relevant.
m32r.zip

[GhidrAuto]

I think I figured out what is wrong. There is no manifest file in this m32r file. can you send that too me, or update the github possibly? and or how would I creat one?

…

On Wed, Mar 6, 2024 at 8:37 PM rimwall ***@***.***> wrote: Hi, so long ago I can't remember. Looks like I made some changes to two of the files (attached). I am using Ghidra 10.1 if that's relevant. m32r.zip <https://github.com/ripnet/ghidra-m32r/files/14518797/m32r.zip> — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYPNSPIMPWWQXDEZXXF3I2LYW7VKLAVCNFSM6AAAAAATGK5FBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSGMZTEOBRGA> . You are receiving this because you commented.Message ID: ***@***.***>

[rimwall]

A module.manifest file is required for all processors, but most of the time they are just blank files. My m32r manifest file is a blank file. Just copy a blank file from another processor and put it in ../Processors/m32r/That should do it.Sent from my iPhoneOn 13 Mar 2024, at 3:57 pm, GhidrAuto ***@***.***> wrote: I think I figured out what is wrong. There is no manifest file in this m32r file. can you send that too me, or update the github possibly? and or how would I creat one?

On Wed, Mar 6, 2024 at 8:37 PM rimwall ***@***.***> wrote: Hi, so long ago I can't remember. Looks like I made some changes to two of the files (attached). I am using Ghidra 10.1 if that's relevant. m32r.zip <https://github.com/ripnet/ghidra-m32r/files/14518797/m32r.zip> — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYPNSPIMPWWQXDEZXXF3I2LYW7VKLAVCNFSM6AAAAAATGK5FBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSGMZTEOBRGA> . You are receiving this because you commented.Message ID: ***@***.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[GhidrAuto]

Okay copy. I’ll try that on my other laptop as a quick test. Last night I ended up downloading eclipse, creating new module, and then copied all the files into the new processor folder that I created with eclipse. It worked. Thanks for your help. I have a YouTube channel https://youtu.be/jRo1wr7o80g?si=8_n7lyxfS8g56vEq . I am using ghidra too reverse engineer automotive ecus. I have zero experience with coding or any thing like this, so I struggle a bit if shit doesn’t work. But once it’s working I tend to be finding some quick success for in disassembly though! No processor patches yet. In time.

…

On Wed, Mar 13, 2024 at 9:13 PM rimwall ***@***.***> wrote: A module.manifest file is required for all processors, but most of the time they are just blank files. My m32r manifest file is a blank file. Just copy a blank file from another processor and put it in ../Processors/m32r/That should do it.Sent from my iPhoneOn 13 Mar 2024, at 3:57 pm, GhidrAuto ***@***.***> wrote: I think I figured out what is wrong. There is no manifest file in this m32r file. can you send that too me, or update the github possibly? and or how would I creat one? On Wed, Mar 6, 2024 at 8:37 PM rimwall ***@***.***> wrote: > Hi, so long ago I can't remember. Looks like I made some changes to two of > the files (attached). I am using Ghidra 10.1 if that's relevant. > m32r.zip <https://github.com/ripnet/ghidra-m32r/files/14518797/m32r.zip> > > — > Reply to this email directly, view it on GitHub > <#2 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AYPNSPIMPWWQXDEZXXF3I2LYW7VKLAVCNFSM6AAAAAATGK5FBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSGMZTEOBRGA> > . > You are receiving this because you commented.Message ID: > ***@***.***> > —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***> — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYPNSPOAYCNJQGT3NNEWPHLYYEPVRAVCNFSM6AAAAAATGK5FBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJWGM3DOMBXGU> . You are receiving this because you commented.Message ID: ***@***.***>