Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version information to API #57

Open
gavv opened this issue Feb 5, 2023 · 7 comments
Open

Add version information to API #57

gavv opened this issue Feb 5, 2023 · 7 comments
Assignees
Labels
api Changes in public API good first issue Good for newcomers help wanted Contributions are welcome

Comments

@gavv
Copy link
Member

gavv commented Feb 5, 2023

C library provides version info: https://roc-streaming.org/toolkit/docs/api/reference.html#roc-version

It would be nice to add this feature to the java library too. We need to provide two versions actually: version of the native library (libroc), and version of the bindings (which may be slightly different).

This issue requires updating both JNI and java parts.

@gavv gavv added enhancement New feature or request good first issue Good for newcomers help wanted Contributions are welcome labels Feb 5, 2023
@gavv gavv added api Changes in public API and removed enhancement New feature or request labels Apr 3, 2023
@gavv gavv pinned this issue Sep 30, 2023
@saurabhyadav1985

This comment was marked as outdated.

@gavv

This comment was marked as outdated.

@gavv

This comment was marked as outdated.

@ayushkumar105
Copy link

@gavv Can I work on this issue and 83?

@gavv
Copy link
Member Author

gavv commented Aug 3, 2024

Sure, thanks!

Note that roc-java is not yet updated to the latest roc-toolkit, so you'll need to install roc-toolkit from 0.2.x tag rather than from master.

@gavv
Copy link
Member Author

gavv commented Oct 12, 2024

@ayushkumar105 Hi, still have plans on this?

@ayushkumar105
Copy link

@gavv Yes, although I will only have time during December. Currently my college semester is ongoing so I don't really have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Changes in public API good first issue Good for newcomers help wanted Contributions are welcome
Projects
None yet
Development

No branches or pull requests

3 participants