Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PulseAudio automatic sink input latency #18

Open
gavv opened this issue Mar 31, 2019 · 0 comments
Open

PulseAudio automatic sink input latency #18

gavv opened this issue Mar 31, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@gavv
Copy link
Member

gavv commented Mar 31, 2019

PulseAudio can automatically adjust sink latency. When this happens, the size of the buffer requested from sink inputs is changed as well.

We should handle these updates:

  • If the buffer size is larger than our target latency, we should increase our target latency, or the playback will break otherwise.

  • If the buffer size is smaller than our target latency and the network latency is small too, we can decrease our target latency.

We should add support for changing target latency dynamically. There are two sources of the target latency updates: we can measure network latency during RTCP and we can get sink latency updates from PulseAudio. Then we should use the maximum latency of these two.

In this issue, we should do the following:

  • add support for changing target latency at runtime
  • handle PulseAudio latency updates (we likely should implement update_sink_requested_latency callback)
@gavv gavv added the enhancement New feature or request label Mar 31, 2019
@gavv gavv transferred this issue from roc-streaming/roc-toolkit Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant