Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect sample rate in module-roc-sink-input #9

Closed
gavv opened this issue Dec 18, 2017 · 1 comment
Closed

Detect sample rate in module-roc-sink-input #9

gavv opened this issue Dec 18, 2017 · 1 comment
Labels
duplicate Already addressed by another issue or pull request enhancement New feature or request

Comments

@gavv
Copy link
Member

gavv commented Dec 18, 2017

Currently, we unconditionally set 44100, which may cause unnecessary resampling. It would be better to use the sink's rate instead.

@gavv gavv added the enhancement New feature or request label Dec 18, 2017
@gavv gavv changed the title Detect sample rate module-roc-sink-input Detect sample rate in module-roc-sink-input Dec 18, 2017
@gavv
Copy link
Member Author

gavv commented Apr 23, 2019

Duplicate of #16.

@gavv gavv closed this as completed Apr 23, 2019
@gavv gavv added the duplicate Already addressed by another issue or pull request label Apr 23, 2019
@gavv gavv transferred this issue from roc-streaming/roc-toolkit Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Already addressed by another issue or pull request enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant