From 606241456bdf23a6900c3c4d86b92f13da868bf4 Mon Sep 17 00:00:00 2001 From: Lennart Nachtigall Date: Thu, 30 Nov 2023 15:07:34 +0100 Subject: [PATCH 1/2] Inactive controllers are just reported as a ros diagnositcs warning now --- controller_manager/src/controller_manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controller_manager/src/controller_manager.cpp b/controller_manager/src/controller_manager.cpp index 4ffaef24aa..fd23b2145d 100644 --- a/controller_manager/src/controller_manager.cpp +++ b/controller_manager/src/controller_manager.cpp @@ -2558,7 +2558,7 @@ void ControllerManager::controller_activity_diagnostic_callback( } else { - stat.summary(diagnostic_msgs::msg::DiagnosticStatus::ERROR, "Not all controllers are active"); + stat.summary(diagnostic_msgs::msg::DiagnosticStatus::WARN, "Not all controllers are active"); } } From 87c5976398e3fe3610cb7ffeecf6b75004d98276 Mon Sep 17 00:00:00 2001 From: Bence Magyar Date: Mon, 4 Dec 2023 10:00:06 +0000 Subject: [PATCH 2/2] Update controller_manager/src/controller_manager.cpp --- controller_manager/src/controller_manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controller_manager/src/controller_manager.cpp b/controller_manager/src/controller_manager.cpp index fd23b2145d..b1127e000b 100644 --- a/controller_manager/src/controller_manager.cpp +++ b/controller_manager/src/controller_manager.cpp @@ -2558,7 +2558,7 @@ void ControllerManager::controller_activity_diagnostic_callback( } else { - stat.summary(diagnostic_msgs::msg::DiagnosticStatus::WARN, "Not all controllers are active"); + stat.summary(diagnostic_msgs::msg::DiagnosticStatus::OK, "Not all controllers are active"); } }