Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add clear timeline button #41

Closed
wants to merge 2 commits into from
Closed

[WIP] Add clear timeline button #41

wants to merge 2 commits into from

Conversation

VictorLamoine
Copy link
Contributor

@VictorLamoine VictorLamoine commented Apr 4, 2019

⚠️ Work in progress ⚠️

Fixes #39
This pull requests adds a button "Clear timeline" that clears all loaded bags so far so that we can start anew without closing/opening rqt_bag application.


I need help here, I don't know how to properly clear the timeline so that we can load a new bag like when application just started. The following code needs to be fixed as it is clearly wrong (leads to application crash)

def clear(self):
"""
clears all previously loaded bags
"""
# FIXME Wrong
self._playhead_positions.clear()
self._messages_cvs.clear()
self._message_loaders.clear()
self._timeline_frame.reset_timeline()
del self._bags[:]

@dirk-thomas
Copy link
Contributor

@VictorLamoine Are you still working on this or should this be closed?

@VictorLamoine
Copy link
Contributor Author

Not working on this at the moment. I will reopen if I manage to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to load a bag file without appending to the current timeline
2 participants