Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff produces a broken table #12

Open
Boulder08 opened this issue Sep 30, 2023 · 2 comments
Open

Diff produces a broken table #12

Boulder08 opened this issue Sep 30, 2023 · 2 comments

Comments

@Boulder08
Copy link

Diff'ing these two files produces a broken film grain table. The coefficients are b0rked somehow, and if you use the table in aomenc, you get a very interesting grain layer there..

https://drive.google.com/file/d/1V2e8DRlNO_KGfEVfiRWO83dwSV2YthkB/view?usp=drive_link
https://drive.google.com/file/d/1hVUvOne-WRNX2QpYfY8w8XETBjQbtedN/view?usp=drive_link
tng s06e02_grain.txt

The same happens if you use the original source (1080p) and crop the left and right side borders (244 pixels both) off and try working on that without downscaling to 720p. If you crop and add the borders back before encoding the reference and lossless clip, no problems so the problem is somewhere in grav1synth.

I also tried various cropping parameters but none of them worked. Cropping the top and bottom borders has not caused any problems in my tests.

@Boulder08
Copy link
Author

Looks like widths 1920 and 1280 work. Others have issues, didn't test higher ones yet.

@Boulder08
Copy link
Author

Some tests with various widths:
3840 ok
3600 not ok
3584 ok
2960 not ok
2880 not ok
2560 ok
1920 ok
1480 ok
1460 not ok
1456 not ok
1280 ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant