-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this repo abandoned? #681
Comments
@kevinji I take the lack of response as a yes ... |
It would be good if repo owner assign several people as maintainers, to review pools requests and merge PRs. |
I've actually been working on a fork of this repo here: https://github.com/jamesgraves/rust-cookbook I've only gotten through about half of the examples, and have to convert the other half, even before adding a whole bunch more. The CHANGES.md file explains what I've been going for. I'd been sort of waiting until I finished with the conversion before approaching the current project maintainers (if they can even be contacted), but I am open to accepting help already. There are bunches of examples that could be added (no particular order):
The only limit is available free time... |
This is excellent @jamesgraves I am rookie rust developer myself but I am very willing to help in any way I can. I'm coming from backend api development with nodeTS background. Please let me know of any way I can be useful to this course. |
I will accept pull requests. If you want to convert some existing samples, great. If you want to add a new one, also great. For the existing examples, I was going in alphabetical order, and stopped before getting to |
Hi, |
@jamesgraves do you want to help maintain the official one? You work could benefit from the search traffic. |
Andrew Gauger ***@***.***> wrote:
@jamesgraves <https://github.com/jamesgraves> do you want to help
maintain the official one? You work could benefit from the search traffic.
I was intending to ask to take over the project, but I haven't converted /
upgraded all the existing examples yet, so I was waiting. I'm actually
mostly done, except for the web request stuff, and giving everything
another proofread and edit.
If you all think it is in a good enough state as it is, I'd be glad to
merge all this into the official Cookbook repository.
All the examples I have converted are mostly up-to-date with current stable
versions of the libraries. However, changes to cargo update and cargo
upgrade now *don't* upgrade to a newer stable version of the crate that
possibly has breaking API changes. So there are some further updates needed
there.
**Edit:** It turns out you can run `cargo upgrade -Z unstable options --breaking` to upgrade to the latest version, but that only works on the nightly channel for `cargo`.
I have made *extensive *changes though: with regards to how the examples
are presented, how they are implemented, and how everything is built and
run. The CHANGES.md gives an overview:
https://github.com/jamesgraves/rust-cookbook/blob/main/CHANGES.md
I don't expect that everyone would agree that these changes are desirable,
so I was expecting there would be a lot of discussion about all that.
Let me know, I'd be glad to help.
|
I like the way skeptic and cargo.toml are preserved over the src directory. I don't want to cast a verdict over the future, but I'm going to close this issue and un-abandon the cookbook 🎉 |
I actually just started to write up an issue about moving the code to actual rust files and importing using mdbook includes, and then found this issue. Strong +1 that doing this is the right thing to do. Strong agreement with all the listed things in the CHANGES doc. @AndyGauge can you clarify what you meant by. It's not clear if you're saying that you like the changes @jamesgraves made or you're rejecting them.
|
I have pulled both repositories and reviewed them since closing the issue. I am saying that it is a lot to take in at once, and I'm trying to get the changes that contributors have made merged and deployed. Please write up an issue with the recommendation to remove skeptic so we can get consensus. I already did 1 and 6 this week. |
Seems like there hasn't been any activity for almost 2 years; has this repo been abandoned? Should the community fork it to keep it alive?
The text was updated successfully, but these errors were encountered: