Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] Enable HTTP request caching #16

Open
webknjaz opened this issue Jul 27, 2019 · 6 comments
Open

[TODO] Enable HTTP request caching #16

webknjaz opened this issue Jul 27, 2019 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@webknjaz
Copy link
Member

webknjaz commented Jul 27, 2019 •
edited by polar-sh bot
Loading

AFAIR this can be wired up on the router level.

Fund with Polar
@webknjaz webknjaz added enhancement New feature or request good first issue Good for newcomers labels Jul 27, 2019
@pradyunsg
Copy link
Collaborator

pradyunsg commented Jul 29, 2019 •
edited
Loading

You might be able to use cachecontrol here.

might

@webknjaz
Copy link
Member Author

Yeah. I know :) I just didn't do this. There's a native feature in Gidgethub for that.

@webknjaz
Copy link
Member Author

I was actually in the wrong repo. This should be sanitizers/octomachinery#17.

@pradyunsg
Copy link
Collaborator

Hehe. Cool cool. 😬

My lack of knowledge in this department shows. 🙃

@webknjaz
Copy link
Member Author

That's okay ;)
This is only needed as a means to avoid hitting the rate limit. GitHub's docs say that if the resource hasn't changed it'll not be counted towards the used requests counter.

@webknjaz
Copy link
Member Author

Pointers: sanitizers/octomachinery#17 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webknjaz @pradyunsg