Repository navigation
Expand file tree
/
Copy pathpackage_test.go
More file actions
986 lines (942 loc) · 36.5 KB
/
Copy pathpackage_test.go
File metadata and controls
986 lines (942 loc) · 36.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
package main
import (
"bytes"
"context"
"encoding/json"
"errors"
"os"
"path/filepath"
"strconv"
"strings"
"syscall"
"testing"
"time"
"github.com/klauspost/compress/zstd"
"github.com/saveweb/go2internetarchive/pkg/upload"
"github.com/saveweb/mergewarc"
)
func TestPackagingConfig(t *testing.T) {
path := writePackagingTestConfig(t, 1024, 512, "24h")
cfg, err := loadConfig(path)
if err != nil {
t.Fatal(err)
}
packaging := cfg.Projects["test"].Packaging
if packaging.TriggerBytes != 1024 || packaging.TargetPackageBytes != 512 || packaging.maxWait != 24*time.Hour {
t.Fatalf("packaging = %+v", packaging)
}
for _, test := range []struct {
trigger int64
target int64
wait string
}{
{511, 512, "24h"}, {1024, 0, "24h"}, {1024, 512, "500ms"},
} {
if _, err := loadConfig(writePackagingTestConfig(t, test.trigger, test.target, test.wait)); err == nil {
t.Fatalf("accepted packaging trigger=%d target=%d wait=%q", test.trigger, test.target, test.wait)
}
}
}
func TestIdentityPackagingConfigRequiresNoThresholds(t *testing.T) {
raw := `{
"listen_addr":":8080","issuer":"https://canner.example","data_dir":"` + t.TempDir() + `",
"max_upload_bytes":1024,"min_free_bytes":1,
"projects":{"test":{"packaging":{"type":"identity"},"delivery":{
"sink":"internet_archive","credentials_file":"unused","identifier":"{{PACKAGE_ID}}",
"remote_name":"{{PACKAGE_FILENAME}}","local_artifact_retention":"1h"}}}}`
path := filepath.Join(t.TempDir(), "config.json")
if err := os.WriteFile(path, []byte(raw), 0o600); err != nil {
t.Fatal(err)
}
if _, err := loadConfig(path); err != nil {
t.Fatal(err)
}
}
func TestRequirePackageStorage(t *testing.T) {
dataDir := t.TempDir()
anchor := filepath.Join(dataDir, "packages", packageDirectoryAnchor)
if err := requirePackageStorage(dataDir); err == nil || !strings.Contains(err.Error(), "packages storage is not mounted") {
t.Fatalf("missing anchor error = %v", err)
}
if err := os.MkdirAll(anchor, 0o750); err != nil {
t.Fatal(err)
}
if err := requirePackageStorage(dataDir); err == nil || !strings.Contains(err.Error(), "not a regular file") {
t.Fatalf("directory anchor error = %v", err)
}
if err := os.Remove(anchor); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(anchor, nil, 0o640); err != nil {
t.Fatal(err)
}
if err := requirePackageStorage(dataDir); err != nil {
t.Fatalf("regular anchor: %v", err)
}
}
func TestMaterializeIdentityPayloadAcrossFilesystems(t *testing.T) {
sourcePath := filepath.Join(t.TempDir(), "source")
body := []byte("identity package")
if err := os.WriteFile(sourcePath, body, 0o640); err != nil {
t.Fatal(err)
}
destination, err := os.CreateTemp("/dev/shm", ".canner-identity-test-*")
if err != nil {
t.Skipf("create destination on /dev/shm: %v", err)
}
destinationPath := destination.Name()
if err := destination.Close(); err != nil {
t.Fatal(err)
}
if err := os.Remove(destinationPath); err != nil {
t.Fatal(err)
}
defer os.Remove(destinationPath)
probePath := destinationPath + ".probe"
if err := os.Link(sourcePath, probePath); err == nil {
os.Remove(probePath)
t.Skip("test directories are on the same filesystem")
} else if !errors.Is(err, syscall.EXDEV) {
t.Skipf("cannot verify cross-filesystem link behavior: %v", err)
}
if err := materializeIdentityPayload(sourcePath, destinationPath); err != nil {
t.Fatal(err)
}
got, err := os.ReadFile(destinationPath)
if err != nil {
t.Fatal(err)
}
if !bytes.Equal(got, body) {
t.Fatalf("identity package bytes = %q", got)
}
info, err := os.Stat(destinationPath)
if err != nil {
t.Fatal(err)
}
if info.Mode().Perm() != 0o640 {
t.Fatalf("identity package mode = %o", info.Mode().Perm())
}
}
func TestPackageDeliveryPlanUsesShortPackageID(t *testing.T) {
packageID := strings.Repeat("a", 64)
plan, err := makePackageDeliveryPlan("sinavideo", packageID, "package.warc.zst", "package.manifest.jsonl", time.Date(2026, 8, 12, 0, 50, 2, 0, time.UTC), deliveryConfig{
Sink: "internet_archive", Identifier: "saveweb_sinavideo_{{DATE}}_{{PACKAGE_ID_SHORT}}", RemoteName: "{{PACKAGE_FILENAME}}",
})
if err != nil {
t.Fatal(err)
}
if want := "saveweb_sinavideo_20260812005002_" + packageID[:24]; plan.Identifier != want {
t.Fatalf("identifier = %q, want %q", plan.Identifier, want)
}
}
func TestPackageDeliveryPlanRejectsInvalidIAIdentifier(t *testing.T) {
for _, identifier := range []string{"four", "-starts-with-dash", "contains:colon", strings.Repeat("a", 101)} {
_, err := makePackageDeliveryPlan("test", strings.Repeat("a", 64), "package", "manifest", time.Unix(0, 0), deliveryConfig{
Sink: "internet_archive", Identifier: identifier, RemoteName: "{{PACKAGE_FILENAME}}",
})
if err == nil {
t.Fatalf("accepted invalid IA identifier %q", identifier)
}
}
}
func TestClaimPackageBuildClearsRetryError(t *testing.T) {
store, err := openDeliveryStore(t.TempDir())
if err != nil {
t.Fatal(err)
}
defer store.close()
if _, err := store.db.Exec(`INSERT INTO packages(package_id,project,packager,filename,manifest_filename,state,member_count,build_attempts,next_build_at,build_error,updated_at,created_at) VALUES('package','test','identity','package','manifest','building',1,1,100,'temporary failure',50,50)`); err != nil {
t.Fatal(err)
}
pkg, ok, err := store.nextBuildingPackage(t.Context(), 100)
if err != nil || !ok {
t.Fatalf("claim package = %+v, %v, %v", pkg, ok, err)
}
if pkg.BuildError != nil || pkg.BuildAttempts != 2 {
t.Fatalf("claimed package = %+v", pkg)
}
}
func TestIdentityPackageUsesOriginalArtifactBytes(t *testing.T) {
cfg := testConfig(t)
project := cfg.Projects["test"]
project.Packaging = packagingConfig{Type: "identity"}
project.Delivery = deliveryConfig{
Sink: "internet_archive", CredentialsFile: "unused", Identifier: "identity-{{PACKAGE_ID}}",
RemoteName: "{{PACKAGE_FILENAME}}", localArtifactRetention: time.Hour,
}
cfg.Projects["test"] = project
s, err := newServer(cfg)
if err != nil {
t.Fatal(err)
}
defer s.deliveryStore.close()
s.now = func() time.Time { return time.Unix(50, 0) }
body := []byte("an arbitrary non-WARC artifact")
acceptTestArtifact(t, s, body)
worker := newDeliveryWorker(cfg, s.deliveryStore)
worker.now = s.now
packageDir := filepath.Join(cfg.DataDir, "packages")
if worked, err := worker.runPackageBuildCycle(t.Context()); err != nil || !worked {
t.Fatalf("identity build = %v, %v", worked, err)
}
packages, err := s.deliveryStore.listPackages(t.Context())
if err != nil {
t.Fatal(err)
}
if len(packages) != 1 || packages[0].Packager != "identity" || packages[0].State != "sealed" || packages[0].MemberCount != 1 {
t.Fatalf("packages = %+v", packages)
}
pkg := packages[0]
members, err := s.deliveryStore.packageMembers(t.Context(), pkg.PackageID)
if err != nil || len(members) != 1 {
t.Fatalf("members = %+v, %v", members, err)
}
sourcePath := filepath.Join(cfg.DataDir, "uploads", members[0].ObjectID)
packagePath := filepath.Join(packageDir, pkg.Filename)
if _, err := os.Stat(filepath.Join(cfg.DataDir, "packages", packageDirectoryAnchor)); err != nil {
t.Fatalf("package directory anchor: %v", err)
}
sourceInfo, err := os.Stat(sourcePath)
if err != nil {
t.Fatal(err)
}
packageInfo, err := os.Stat(packagePath)
if err != nil {
t.Fatal(err)
}
if !os.SameFile(sourceInfo, packageInfo) {
t.Fatal("identity package copied bytes instead of using the original artifact inode")
}
manifestRaw, err := os.ReadFile(filepath.Join(cfg.DataDir, "package-manifests", pkg.ManifestFilename))
if err != nil {
t.Fatal(err)
}
if !bytes.Contains(manifestRaw, []byte(`"checksums":`)) || bytes.Contains(manifestRaw, []byte(`"checksum":`)) {
t.Fatalf("identity manifest uses obsolete checksum schema: %s", manifestRaw)
}
if worked, err := worker.runPackagedSourcePurgeCycle(t.Context()); err != nil || !worked {
t.Fatalf("identity source purge = %v, %v", worked, err)
}
if _, err := os.Stat(sourcePath); !os.IsNotExist(err) {
t.Fatalf("identity source still exists: %v", err)
}
got, err := os.ReadFile(packagePath)
if err != nil || !bytes.Equal(got, body) {
t.Fatalf("identity package bytes = %q, %v", got, err)
}
}
func TestPackageDeliveryFailureAndRestartAreRetryable(t *testing.T) {
dir := t.TempDir()
store, err := openDeliveryStore(dir)
if err != nil {
t.Fatal(err)
}
defer store.close()
plan, err := json.Marshal(packageDeliveryPlan{
Version: 1, Sink: "internet_archive", CredentialsFile: "unused", Identifier: "item",
Files: map[string]string{"package": "package"}, RetentionNanos: int64(time.Hour),
})
if err != nil {
t.Fatal(err)
}
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO packages(package_id,project,packager,filename,manifest_filename,state,size_bytes,checksum,manifest_checksum,member_count,next_build_at,updated_at,created_at,sealed_at) VALUES('package','test','identity','package','package.manifest.jsonl','sealed',1,'blake3:00','blake3:00',1,0,100,100,100)`); err != nil {
t.Fatal(err)
}
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO deliveries(package_id,sink_id,state,plan,next_attempt_at,updated_at) VALUES('package','internet_archive','pending',?,100,100)`, string(plan)); err != nil {
t.Fatal(err)
}
worker := newDeliveryWorker(runtimeConfig{config: config{DataDir: dir}}, store)
worker.now = func() time.Time { return time.Unix(100, 0) }
wantErr := errors.New("sink unavailable")
worker.deliverPackage = func(context.Context, packageDeliveryPlan, string, chan<- upload.Progress) error { return wantErr }
if worked, err := worker.runPackageDeliveryCycle(t.Context()); err != nil || !worked {
t.Fatalf("delivery failure = %v, %v", worked, err)
}
deliveries, err := store.listDeliveries(t.Context())
if err != nil {
t.Fatal(err)
}
if len(deliveries) != 1 || deliveries[0].State != "retry_wait" || deliveries[0].Attempts != 1 || deliveries[0].NextAttempt != 160 || deliveries[0].LastError == nil || *deliveries[0].LastError != wantErr.Error() {
t.Fatalf("delivery after failure = %+v", deliveries)
}
if _, err := store.db.ExecContext(t.Context(), `UPDATE deliveries SET state='delivering' WHERE package_id='package'`); err != nil {
t.Fatal(err)
}
if err := store.recoverInterruptedDeliveries(t.Context(), 200); err != nil {
t.Fatal(err)
}
deliveries, err = store.listDeliveries(t.Context())
if err != nil {
t.Fatal(err)
}
if deliveries[0].State != "retry_wait" || deliveries[0].NextAttempt != 200 {
t.Fatalf("delivery after restart = %+v", deliveries[0])
}
}
func TestClaimPackageDeliveryPrefersPendingOverRetry(t *testing.T) {
store, err := openDeliveryStore(t.TempDir())
if err != nil {
t.Fatal(err)
}
defer store.close()
for _, delivery := range []struct {
packageID string
state string
createdAt int
}{
{packageID: "old-retry", state: "retry_wait", createdAt: 1},
{packageID: "new-pending", state: "pending", createdAt: 2},
} {
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO packages(package_id,project,packager,filename,manifest_filename,state,size_bytes,checksum,manifest_checksum,member_count,next_build_at,updated_at,created_at,sealed_at) VALUES(?,'test','identity',?,?,'sealed',1,'blake3:00','blake3:00',1,0,?,?,?)`, delivery.packageID, delivery.packageID, delivery.packageID+".manifest", delivery.createdAt, delivery.createdAt, delivery.createdAt); err != nil {
t.Fatal(err)
}
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO deliveries(package_id,sink_id,state,plan,next_attempt_at,updated_at) VALUES(?,'internet_archive',?, '{}',0,?)`, delivery.packageID, delivery.state, delivery.createdAt); err != nil {
t.Fatal(err)
}
}
delivery, ok, err := store.claimPackageDelivery(t.Context(), 100)
if err != nil || !ok {
t.Fatalf("claim delivery = %+v, %v, %v", delivery, ok, err)
}
if delivery.PackageID != "new-pending" {
t.Fatalf("claimed %q before fresh pending delivery", delivery.PackageID)
}
}
func TestPackageDeliveryPersistsProgressWhileRunning(t *testing.T) {
dir := t.TempDir()
store, err := openDeliveryStore(dir)
if err != nil {
t.Fatal(err)
}
defer store.close()
plan, err := json.Marshal(packageDeliveryPlan{
Version: 1, Sink: "internet_archive", CredentialsFile: "unused", Identifier: "item",
Files: map[string]string{"package": "package"}, RetentionNanos: int64(time.Hour),
})
if err != nil {
t.Fatal(err)
}
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO packages(package_id,project,packager,filename,manifest_filename,state,size_bytes,checksum,manifest_checksum,member_count,next_build_at,updated_at,created_at,sealed_at) VALUES('package','test','identity','package','manifest','sealed',100,'blake3:00','blake3:00',1,0,100,100,100)`); err != nil {
t.Fatal(err)
}
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO deliveries(package_id,sink_id,state,plan,next_attempt_at,updated_at) VALUES('package','internet_archive','pending',?,100,100)`, string(plan)); err != nil {
t.Fatal(err)
}
worker := newDeliveryWorker(runtimeConfig{config: config{DataDir: dir}}, store)
worker.now = func() time.Time { return time.Unix(100, 0) }
progressRecorded := make(chan struct{})
finish := make(chan struct{})
worker.deliverPackage = func(_ context.Context, _ packageDeliveryPlan, _ string, progress chan<- upload.Progress) error {
progress <- upload.Progress{BytesUploaded: 40, TotalBytes: 100, BytesPerSecond: 20, CurrentFile: "package"}
close(progressRecorded)
<-finish
return errors.New("stop after snapshot")
}
result := make(chan error, 1)
go func() {
_, err := worker.runPackageDeliveryCycle(t.Context())
result <- err
}()
<-progressRecorded
var raw *string
for deadline := time.Now().Add(time.Second); time.Now().Before(deadline); {
if err := store.db.QueryRow(`SELECT progress FROM deliveries WHERE package_id='package'`).Scan(&raw); err != nil {
t.Fatal(err)
}
if raw != nil {
break
}
time.Sleep(time.Millisecond)
}
if raw == nil || !strings.Contains(*raw, `"BytesUploaded":40`) {
t.Fatalf("progress while running = %v", raw)
}
close(finish)
if err := <-result; err != nil {
t.Fatal(err)
}
if err := store.db.QueryRow(`SELECT progress FROM deliveries WHERE package_id='package'`).Scan(&raw); err != nil || raw != nil {
t.Fatalf("progress after completion = %v, %v", raw, err)
}
}
func TestDeliverySchedulerBoundsConcurrencyAndRecoversCancellation(t *testing.T) {
dir := t.TempDir()
store, err := openDeliveryStore(dir)
if err != nil {
t.Fatal(err)
}
defer store.close()
for i, identifier := range []string{"item-a", "item-b", "item-c"} {
packageID := "package-" + identifier
plan, err := json.Marshal(packageDeliveryPlan{
Version: 1, Sink: "internet_archive", CredentialsFile: "unused", Identifier: identifier,
Files: map[string]string{packageID: packageID}, RetentionNanos: int64(time.Hour),
})
if err != nil {
t.Fatal(err)
}
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO packages(package_id,project,packager,filename,manifest_filename,state,size_bytes,checksum,manifest_checksum,member_count,next_build_at,updated_at,created_at,sealed_at) VALUES(?, 'test','identity',?,?,'sealed',1,'blake3:00','blake3:00',1,0,?,?,?)`, packageID, packageID, packageID+".manifest", 100+i, 100+i, 100+i); err != nil {
t.Fatal(err)
}
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO deliveries(package_id,sink_id,state,plan,next_attempt_at,updated_at) VALUES(?,'internet_archive','pending',?,100,100)`, packageID, string(plan)); err != nil {
t.Fatal(err)
}
}
cfg := runtimeConfig{config: config{DataDir: dir, DeliveryConcurrency: 2}}
worker := newDeliveryWorker(cfg, store)
worker.now = func() time.Time { return time.Unix(100, 0) }
started := make(chan string, 3)
release := map[string]chan struct{}{"item-a": make(chan struct{}), "item-b": make(chan struct{}), "item-c": make(chan struct{})}
worker.deliverPackage = func(ctx context.Context, plan packageDeliveryPlan, _ string, _ chan<- upload.Progress) error {
started <- plan.Identifier
select {
case <-release[plan.Identifier]:
return nil
case <-ctx.Done():
return ctx.Err()
}
}
ctx, cancel := context.WithCancel(t.Context())
result := make(chan error, 1)
go func() { result <- worker.runScheduler(ctx) }()
first := waitForStartedDelivery(t, started)
second := waitForStartedDelivery(t, started)
select {
case third := <-started:
t.Fatalf("started %q while %q and %q were active", third, first, second)
case <-time.After(50 * time.Millisecond):
}
close(release[first])
third := waitForStartedDelivery(t, started)
if third == first || third == second {
t.Fatalf("third delivery = %q after starting %q and %q", third, first, second)
}
cancel()
if err := <-result; err != nil {
t.Fatal(err)
}
var delivered, interrupted int
if err := store.db.QueryRow(`SELECT COUNT(*) FROM deliveries WHERE state='delivered'`).Scan(&delivered); err != nil {
t.Fatal(err)
}
if err := store.db.QueryRow(`SELECT COUNT(*) FROM deliveries WHERE state='delivering'`).Scan(&interrupted); err != nil {
t.Fatal(err)
}
if delivered != 1 || interrupted != 2 {
t.Fatalf("after cancellation: delivered=%d delivering=%d", delivered, interrupted)
}
if err := store.recoverInterruptedDeliveries(t.Context(), 200); err != nil {
t.Fatal(err)
}
var retrying int
if err := store.db.QueryRow(`SELECT COUNT(*) FROM deliveries WHERE state='retry_wait' AND next_attempt_at=200`).Scan(&retrying); err != nil {
t.Fatal(err)
}
if retrying != 2 {
t.Fatalf("recovered deliveries = %d", retrying)
}
}
func TestDeliverySchedulerBuildsWhileUploadIsActive(t *testing.T) {
cfg := testConfig(t)
cfg.DeliveryConcurrency = 1
project := cfg.Projects["test"]
project.Packaging = packagingConfig{Type: "identity"}
project.Delivery = deliveryConfig{
Sink: "internet_archive", CredentialsFile: "unused", Identifier: "identity-{{PACKAGE_ID}}",
RemoteName: "{{PACKAGE_FILENAME}}", localArtifactRetention: time.Hour,
}
cfg.Projects["test"] = project
s, err := newServer(cfg)
if err != nil {
t.Fatal(err)
}
defer s.deliveryStore.close()
s.now = func() time.Time { return time.Unix(100, 0) }
acceptTestArtifact(t, s, []byte("first"))
worker := newDeliveryWorker(cfg, s.deliveryStore)
worker.now = s.now
worker.packagingPoll = 10 * time.Millisecond
if worked, err := worker.runPackageBuildCycle(t.Context()); err != nil || !worked {
t.Fatalf("initial package build = %v, %v", worked, err)
}
started := make(chan chan<- upload.Progress, 1)
worker.deliverPackage = func(ctx context.Context, _ packageDeliveryPlan, _ string, progress chan<- upload.Progress) error {
started <- progress
<-ctx.Done()
return ctx.Err()
}
ctx, cancel := context.WithCancel(t.Context())
result := make(chan error, 1)
go func() { result <- worker.runScheduler(ctx) }()
progress := <-started
// Let the independent packaging scheduler observe an empty backlog before
// keeping the delivery side continuously busy with progress updates.
time.Sleep(20 * time.Millisecond)
acceptTestArtifact(t, s, []byte("second"))
stopProgress := make(chan struct{})
progressStopped := make(chan struct{})
go func() {
defer close(progressStopped)
ticker := time.NewTicker(time.Millisecond)
defer ticker.Stop()
for {
select {
case <-stopProgress:
return
case <-ticker.C:
select {
case progress <- upload.Progress{}:
case <-stopProgress:
return
}
}
}
}()
deadline := time.Now().Add(time.Second)
for {
var packages int
if err := s.deliveryStore.db.QueryRow(`SELECT COUNT(*) FROM packages WHERE state='sealed'`).Scan(&packages); err != nil {
t.Fatal(err)
}
if packages == 2 {
break
}
if time.Now().After(deadline) {
t.Fatal("new package was not built while an upload was active")
}
time.Sleep(time.Millisecond)
}
close(stopProgress)
<-progressStopped
cancel()
if err := <-result; err != nil {
t.Fatal(err)
}
}
func TestDeliverySchedulerRecordsProgressWhilePackageBuildIsActive(t *testing.T) {
dir := t.TempDir()
store, err := openDeliveryStore(dir)
if err != nil {
t.Fatal(err)
}
defer store.close()
plan, err := json.Marshal(packageDeliveryPlan{
Version: 1, Sink: "internet_archive", CredentialsFile: "unused", Identifier: "item",
Files: map[string]string{"package": "package"}, RetentionNanos: int64(time.Hour),
})
if err != nil {
t.Fatal(err)
}
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO packages(package_id,project,packager,filename,manifest_filename,state,size_bytes,checksum,manifest_checksum,member_count,next_build_at,updated_at,created_at,sealed_at) VALUES('package','test','identity','package','manifest','sealed',100,'blake3:00','blake3:00',1,0,100,100,100)`); err != nil {
t.Fatal(err)
}
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO deliveries(package_id,sink_id,state,plan,next_attempt_at,updated_at) VALUES('package','internet_archive','pending',?,100,100)`, string(plan)); err != nil {
t.Fatal(err)
}
worker := newDeliveryWorker(runtimeConfig{config: config{DataDir: dir, DeliveryConcurrency: 1}}, store)
worker.now = func() time.Time { return time.Unix(100, 0) }
buildStarted := make(chan struct{})
releaseBuild := make(chan struct{})
worker.buildPackage = func(ctx context.Context) (bool, error) {
close(buildStarted)
select {
case <-releaseBuild:
return false, nil
case <-ctx.Done():
return false, ctx.Err()
}
}
uploadStarted := make(chan chan<- upload.Progress, 1)
worker.deliverPackage = func(ctx context.Context, _ packageDeliveryPlan, _ string, progress chan<- upload.Progress) error {
uploadStarted <- progress
<-ctx.Done()
return ctx.Err()
}
ctx, cancel := context.WithCancel(t.Context())
result := make(chan error, 1)
go func() { result <- worker.runScheduler(ctx) }()
<-buildStarted
progress := <-uploadStarted
progress <- upload.Progress{BytesUploaded: 40, TotalBytes: 100, BytesPerSecond: 20, CurrentFile: "package"}
var raw *string
for deadline := time.Now().Add(time.Second); time.Now().Before(deadline); {
if err := store.db.QueryRow(`SELECT progress FROM deliveries WHERE package_id='package'`).Scan(&raw); err != nil {
t.Fatal(err)
}
if raw != nil {
break
}
time.Sleep(time.Millisecond)
}
if raw == nil || !strings.Contains(*raw, `"BytesUploaded":40`) {
t.Fatalf("progress while package build is active = %v", raw)
}
close(releaseBuild)
cancel()
if err := <-result; err != nil {
t.Fatal(err)
}
}
func TestDeliverySchedulerPackagesWithoutSinkDeliveryAtZeroConcurrency(t *testing.T) {
cfg := testConfig(t)
cfg.DeliveryConcurrency = 0
project := cfg.Projects["test"]
project.Packaging = packagingConfig{Type: "identity"}
project.Delivery = deliveryConfig{
Sink: "internet_archive", CredentialsFile: "unused", Identifier: "identity-{{PACKAGE_ID}}",
RemoteName: "{{PACKAGE_FILENAME}}", localArtifactRetention: time.Hour,
}
cfg.Projects["test"] = project
s, err := newServer(cfg)
if err != nil {
t.Fatal(err)
}
defer s.deliveryStore.close()
s.now = func() time.Time { return time.Unix(100, 0) }
acceptTestArtifact(t, s, []byte("artifact"))
worker := newDeliveryWorker(cfg, s.deliveryStore)
worker.now = s.now
deliveryStarted := make(chan struct{}, 1)
worker.deliverPackage = func(context.Context, packageDeliveryPlan, string, chan<- upload.Progress) error {
deliveryStarted <- struct{}{}
return nil
}
ctx, cancel := context.WithCancel(t.Context())
result := make(chan error, 1)
go func() { result <- worker.runScheduler(ctx) }()
deadline := time.Now().Add(time.Second)
for {
var sealed, pending int
if err := s.deliveryStore.db.QueryRow(`SELECT COUNT(*) FROM packages WHERE state='sealed'`).Scan(&sealed); err != nil {
t.Fatal(err)
}
if err := s.deliveryStore.db.QueryRow(`SELECT COUNT(*) FROM deliveries WHERE state='pending'`).Scan(&pending); err != nil {
t.Fatal(err)
}
if sealed == 1 && pending == 1 {
break
}
if time.Now().After(deadline) {
t.Fatalf("packaging with delivery disabled: sealed=%d pending=%d", sealed, pending)
}
time.Sleep(time.Millisecond)
}
select {
case <-deliveryStarted:
t.Fatal("sink delivery started with zero concurrency")
default:
}
cancel()
if err := <-result; err != nil {
t.Fatal(err)
}
}
func waitForStartedDelivery(t *testing.T, started <-chan string) string {
t.Helper()
select {
case identifier := <-started:
return identifier
case <-time.After(time.Second):
t.Fatal("timed out waiting for delivery to start")
return ""
}
}
func TestPackagePurgeWaitsForEveryDelivery(t *testing.T) {
store, err := openDeliveryStore(t.TempDir())
if err != nil {
t.Fatal(err)
}
defer store.close()
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO packages(package_id,project,packager,filename,manifest_filename,state,size_bytes,checksum,manifest_checksum,member_count,next_build_at,updated_at,created_at,sealed_at) VALUES('package','test','identity','package','manifest','sealed',1,'blake3:00','blake3:00',1,0,100,100,100)`); err != nil {
t.Fatal(err)
}
for _, sink := range []string{"archive-a", "archive-b"} {
if _, err := store.db.ExecContext(t.Context(), `INSERT INTO deliveries(package_id,sink_id,state,plan,next_attempt_at,updated_at) VALUES('package',?,'pending','{}',0,100)`, sink); err != nil {
t.Fatal(err)
}
}
if _, err := store.db.ExecContext(t.Context(), `UPDATE deliveries SET state='delivering' WHERE package_id='package' AND sink_id='archive-a'`); err != nil {
t.Fatal(err)
}
if err := store.markPackageDelivered(t.Context(), "package", "archive-a", "remote-a", 101, 110); err != nil {
t.Fatal(err)
}
if _, ok, err := store.nextPackagePurge(t.Context(), 200); err != nil || ok {
t.Fatalf("purge with pending delivery = %v, %v", ok, err)
}
if _, err := store.db.ExecContext(t.Context(), `UPDATE deliveries SET state='delivering' WHERE package_id='package' AND sink_id='archive-b'`); err != nil {
t.Fatal(err)
}
if err := store.markPackageDelivered(t.Context(), "package", "archive-b", "remote-b", 102, 120); err != nil {
t.Fatal(err)
}
if _, ok, err := store.nextPackagePurge(t.Context(), 119); err != nil || ok {
t.Fatalf("early multi-sink purge = %v, %v", ok, err)
}
pkg, ok, err := store.nextPackagePurge(t.Context(), 120)
if err != nil || !ok || pkg.PurgeAfter == nil || *pkg.PurgeAfter != 120 {
t.Fatalf("due multi-sink purge = %+v, %v, %v", pkg, ok, err)
}
}
func TestPackageLifecycle(t *testing.T) {
cfg := testConfig(t)
project := cfg.Projects["test"]
project.Packaging = packagingConfig{Type: "mergewarc", TriggerBytes: 1 << 20, TargetPackageBytes: 1 << 20, MaxWait: "1s", maxWait: time.Second}
project.Delivery = deliveryConfig{
Sink: "internet_archive", CredentialsFile: "unused", Identifier: "sinavideo-{{PACKAGE_ID}}",
RemoteName: "{{PACKAGE_FILENAME}}", LocalArtifactRetention: "2s", localArtifactRetention: 2 * time.Second,
}
cfg.Projects["test"] = project
s, err := newServer(cfg)
if err != nil {
t.Fatal(err)
}
defer s.deliveryStore.close()
now := time.Unix(123456800, 0)
s.now = func() time.Time { return now }
first := testWARCZstd(t, "00000000-0000-0000-0000-000000000001", "one")
second := testWARCZstd(t, "00000000-0000-0000-0000-000000000002", "two")
acceptTestArtifact(t, s, first)
acceptTestArtifact(t, s, second)
worker := newDeliveryWorker(cfg, s.deliveryStore)
worker.now = func() time.Time { return now.Add(time.Second) }
if worked, err := worker.runPackageBuildCycle(t.Context()); err != nil || !worked {
t.Fatalf("build cycle = %v, %v", worked, err)
}
packages, err := s.deliveryStore.listPackages(t.Context())
if err != nil {
t.Fatal(err)
}
if len(packages) != 1 || packages[0].State != "sealed" || packages[0].MemberCount != 2 {
t.Fatalf("packages = %+v", packages)
}
pkg := packages[0]
merged, err := os.ReadFile(filepath.Join(cfg.DataDir, "packages", pkg.Filename))
if err != nil {
t.Fatal(err)
}
manifestFile, err := os.Open(filepath.Join(cfg.DataDir, "package-manifests", pkg.ManifestFilename))
if err != nil {
t.Fatal(err)
}
manifest, err := mergewarc.ReadJSONL(manifestFile)
manifestFile.Close()
if err != nil || len(manifest.Entries) != 2 {
t.Fatalf("manifest = %+v, %v", manifest, err)
}
if len(manifest.Output.Checksums) != 3 {
t.Fatalf("output checksums = %v", manifest.Output.Checksums)
}
blake3Output, err := checksumForAlgorithm(manifest.Output.Checksums, mergewarc.ChecksumBLAKE3)
if err != nil || pkg.Checksum == nil || *pkg.Checksum != blake3Output {
t.Fatalf("stored package checksum = %v, manifest = %v, err = %v", pkg.Checksum, manifest.Output.Checksums, err)
}
remaining := [][]byte{first, second}
for _, entry := range manifest.Entries {
if len(entry.Checksums) != 3 {
t.Fatalf("entry checksums = %v", entry.Checksums)
}
var extracted bytes.Buffer
if err := mergewarc.Extract(t.Context(), bytes.NewReader(merged), entry, &extracted); err != nil {
t.Fatal(err)
}
matched := -1
for i, want := range remaining {
if bytes.Equal(extracted.Bytes(), want) {
matched = i
break
}
}
if matched < 0 {
t.Fatal("manifest entry does not recover an original artifact")
}
remaining = append(remaining[:matched], remaining[matched+1:]...)
}
for range 2 {
if worked, err := worker.runPackagedSourcePurgeCycle(t.Context()); err != nil || !worked {
t.Fatalf("source purge = %v, %v", worked, err)
}
}
for _, entry := range manifest.Entries {
objectID := entry.Metadata["object_id"]
if _, err := os.Stat(filepath.Join(cfg.DataDir, "uploads", objectID)); !os.IsNotExist(err) {
t.Fatalf("source artifact %s still exists: %v", objectID, err)
}
}
var deliveredPlan packageDeliveryPlan
worker.deliverPackage = func(_ context.Context, plan packageDeliveryPlan, _ string, _ chan<- upload.Progress) error {
deliveredPlan = plan
return nil
}
// A later configuration edit must not change the already sealed plan.
changed := worker.cfg.Projects["test"]
changed.Delivery.Identifier = "changed-{{PACKAGE_ID}}"
worker.cfg.Projects["test"] = changed
if worked, err := worker.runPackageDeliveryCycle(t.Context()); err != nil || !worked {
t.Fatalf("delivery cycle = %v, %v", worked, err)
}
if deliveredPlan.Identifier != "sinavideo-"+pkg.PackageID || len(deliveredPlan.Files) != 2 {
t.Fatalf("delivery plan = %+v", deliveredPlan)
}
packages, _ = s.deliveryStore.listPackages(t.Context())
if packages[0].State != "sealed" || packages[0].PurgeAfter == nil || *packages[0].PurgeAfter != now.Add(3*time.Second).Unix() {
t.Fatalf("delivered package = %+v", packages[0])
}
now = now.Add(2 * time.Second)
if worked, err := worker.runPackagePurgeCycle(t.Context()); err != nil || !worked {
t.Fatalf("package purge = %v, %v", worked, err)
}
for _, path := range []string{filepath.Join(cfg.DataDir, "packages", pkg.Filename), filepath.Join(cfg.DataDir, "package-manifests", pkg.ManifestFilename)} {
if _, err := os.Stat(path); !os.IsNotExist(err) {
t.Fatalf("package payload still exists at %s: %v", path, err)
}
}
}
func TestPackageWaitTriggerAndTargetBoundary(t *testing.T) {
store, err := openDeliveryStore(t.TempDir())
if err != nil {
t.Fatal(err)
}
defer store.close()
for i, size := range []int64{6, 6, 6} {
id := "object-" + strconv.Itoa(i)
if err := store.addArtifact(t.Context(), artifactRecord{ObjectID: id, Project: "test", Filename: id + ".warc.zst", Checksum: "blake3:" + string(make([]byte, 64)), SizeBytes: size, AcceptedAt: int64(10 + i)}); err != nil {
t.Fatal(err)
}
}
packaging := packagingConfig{Type: "mergewarc", TriggerBytes: 100, TargetPackageBytes: 10, maxWait: time.Hour}
delivery := deliveryConfig{Sink: "internet_archive", CredentialsFile: "keys", Identifier: "{{PACKAGE_ID}}", RemoteName: "{{PACKAGE_FILENAME}}"}
if _, ok, err := store.reservePackage(t.Context(), "test", packaging, delivery, time.Unix(20, 0)); err != nil || ok {
t.Fatalf("early reserve = %v, %v", ok, err)
}
pkg, ok, err := store.reservePackage(t.Context(), "test", packaging, delivery, time.Unix(3610, 0))
if err != nil || !ok || pkg.MemberCount != 1 {
t.Fatalf("aged reserve = %+v, %v, %v", pkg, ok, err)
}
}
func TestThresholdStartsPersistentDrainingRound(t *testing.T) {
store, err := openDeliveryStore(t.TempDir())
if err != nil {
t.Fatal(err)
}
defer store.close()
for i := range 4 {
id := "drain-" + strconv.Itoa(i)
if err := store.addArtifact(t.Context(), artifactRecord{ObjectID: id, Project: "test", Filename: id + ".warc.zst", Checksum: "blake3:00", SizeBytes: 6, AcceptedAt: int64(10 + i)}); err != nil {
t.Fatal(err)
}
}
packaging := packagingConfig{Type: "mergewarc", TriggerBytes: 18, TargetPackageBytes: 6, maxWait: time.Hour}
delivery := deliveryConfig{Sink: "internet_archive", CredentialsFile: "keys", Identifier: "{{PACKAGE_ID}}", RemoteName: "{{PACKAGE_FILENAME}}"}
for i := range 4 {
pkg, ok, err := store.reservePackage(t.Context(), "test", packaging, delivery, time.Unix(20, 0))
if err != nil || !ok || pkg.MemberCount != 1 {
t.Fatalf("reserve %d = %+v, %v, %v", i, pkg, ok, err)
}
}
if _, ok, err := store.reservePackage(t.Context(), "test", packaging, delivery, time.Unix(20, 0)); err != nil || ok {
t.Fatalf("empty draining round = %v, %v", ok, err)
}
if err := store.addArtifact(t.Context(), artifactRecord{ObjectID: "tail", Project: "test", Filename: "tail.warc.zst", Checksum: "blake3:00", SizeBytes: 6, AcceptedAt: 21}); err != nil {
t.Fatal(err)
}
if _, ok, err := store.reservePackage(t.Context(), "test", packaging, delivery, time.Unix(22, 0)); err != nil || ok {
t.Fatalf("new sub-threshold tail = %v, %v", ok, err)
}
}
func TestInvalidWARCIsIsolatedWithoutBlockingValidArtifacts(t *testing.T) {
cfg := testConfig(t)
project := cfg.Projects["test"]
project.Packaging = packagingConfig{Type: "mergewarc", TriggerBytes: 1 << 20, TargetPackageBytes: 1 << 20, MaxWait: "1s", maxWait: time.Second}
project.Delivery = deliveryConfig{Sink: "internet_archive", CredentialsFile: "unused", Identifier: "{{PACKAGE_ID}}", RemoteName: "{{PACKAGE_FILENAME}}", localArtifactRetention: time.Hour}
cfg.Projects["test"] = project
s, err := newServer(cfg)
if err != nil {
t.Fatal(err)
}
defer s.deliveryStore.close()
s.now = func() time.Time { return time.Unix(100, 0) }
acceptTestArtifact(t, s, []byte("not a WARC-Zstd file"))
acceptTestArtifact(t, s, testWARCZstd(t, "00000000-0000-0000-0000-000000000003", "valid"))
worker := newDeliveryWorker(cfg, s.deliveryStore)
worker.now = func() time.Time { return s.now().Add(time.Second) }
if worked, err := worker.runPackageBuildCycle(t.Context()); err != nil || !worked {
t.Fatalf("invalid build cycle = %v, %v", worked, err)
}
packages, err := s.deliveryStore.listPackages(t.Context())
if err != nil {
t.Fatal(err)
}
if len(packages) != 1 || packages[0].State != "blocked" || packages[0].MemberCount != 1 {
t.Fatalf("packages after invalid input = %+v", packages)
}
var invalid, available int
rows, err := s.deliveryStore.db.QueryContext(t.Context(), `SELECT packaging_error,package_id FROM artifacts`)
if err != nil {
t.Fatal(err)
}
for rows.Next() {
var packagingError, packageID *string
if err := rows.Scan(&packagingError, &packageID); err != nil {
t.Fatal(err)
}
if packagingError != nil {
invalid++
} else if packageID == nil {
available++
}
}
rows.Close()
if invalid != 1 || available != 1 {
t.Fatalf("invalid artifacts = %d, available artifacts = %d", invalid, available)
}
if worked, err := worker.runPackageBuildCycle(t.Context()); err != nil || !worked {
t.Fatalf("valid build cycle = %v, %v", worked, err)
}
packages, err = s.deliveryStore.listPackages(t.Context())
if err != nil {
t.Fatal(err)
}
var sealed int
for _, pkg := range packages {
if pkg.State == "sealed" && pkg.MemberCount == 1 {
sealed++
}
}
if len(packages) != 2 || sealed != 1 {
t.Fatalf("packages after valid retry = %+v", packages)
}
}
func writePackagingTestConfig(t *testing.T, trigger, target int64, wait string) string {
t.Helper()
raw, err := json.Marshal(map[string]any{
"listen_addr": ":8080", "issuer": "https://canner.example", "data_dir": t.TempDir(),
"max_upload_bytes": 2048, "min_free_bytes": 1,
"projects": map[string]any{"test": map[string]any{
"packaging": map[string]any{"type": "mergewarc", "trigger_bytes": trigger, "target_package_bytes": target, "max_wait": wait},
"delivery": map[string]any{"sink": "internet_archive", "credentials_file": "unused", "identifier": "{{PACKAGE_ID}}", "remote_name": "{{PACKAGE_FILENAME}}", "local_artifact_retention": "24h"},
}},
})
if err != nil {
t.Fatal(err)
}
path := filepath.Join(t.TempDir(), "config.json")
if err := os.WriteFile(path, raw, 0o600); err != nil {
t.Fatal(err)
}
return path
}
func testWARCZstd(t *testing.T, id, block string) []byte {
t.Helper()
record := []byte("WARC/1.1\r\n" +
"WARC-Type: metadata\r\n" +
"WARC-Record-ID: <urn:uuid:" + id + ">\r\n" +
"Content-Type: text/plain\r\n" +
"Content-Length: " + strconv.Itoa(len(block)) + "\r\n\r\n" + block + "\r\n\r\n")
encoder, err := zstd.NewWriter(nil, zstd.WithEncoderCRC(true), zstd.WithSingleSegment(true))
if err != nil {
t.Fatal(err)
}
defer encoder.Close()
return encoder.EncodeAll(record, nil)
}