-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vercel login #1025
Comments
That makes sense. Something changed in Vercel. In previous versions, Vercel asked for a login when doing a deployment. I tried logging out locally and I got the same error message. I opened a PR to add this #1027 I can add this information to the SE-2 deployment doc page https://docs.scaffoldeth.io/deploying/deploy-nextjs-app We should update the deployment section from the SpeedRunEthereum challenges too. |
Thanks @damianmarti ! Let's also see what @technophile-04 & @rin-st think |
tldr: I don't see the way to do it better than @damianmarti made for now It would be great if we could use any vercel cli command without adding new script to
So, looks like since If to chose between (1) and (2) I don't know what is better, probably (2) |
I was thinking same option as Rinat suggested (the 2nd one). I think its more future proof. Also the new commands would look more verbose as well. The advantages of that approach:
And also even if we go with So maybe we make that script command breaking changes now itself? Because maybe in future we might need to do this. Lol yeah removing |
Thank you guys! I don't see any option as the clear winner, all have pros/cons. Let's sleep on it and discuss it tomorrow. Question: would it be possible to do some inline conditional magic in the package.json script? Like: if |
I tried to deploy to Vercel from the cli in my new computer:
I got this (which is expected (and stated in the docs)
But then how do I login?
With the current commands (in
package.json
) doesn't seem possible. If I install Vercel cli globally, then it works after login.Should we add
yarn vercel:login
? Or am I missing something?The text was updated successfully, but these errors were encountered: