-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.py does not build with luajit on windows(x64) #235
Comments
It seems that luajit is currently not working with windows as it is written. What worked for me was the following:
This will include the luajit20 and luajit21 third-party folders to also build, leaving you with lua52,lua53,lua54,luajit20 and luajit21 modules. If you additionally want to create a distribution and such, you may also have to mass replace the hard coded absolute paths "/home/runner/work/lupa/lupa/..." to "./lupa/..." |
If someone gets this to work, I'd be happy to receive a PR. |
Thank you, this appears to work. I suppose my question is then why Windows on x64 will not build unless the machine type is specifically not x64 or AMD64? One would think that it would, but I do not know enough about the wizardry that is going on to make a guess as to why it does not work by default. |
This
issue occurs when building with the standard "setup.py build" command, as it completely skips checking and building LuaJit.It succeeds in building Lua51, Lua52, Lua53, and Lua54, and then skips both LuaJit20 and LuaJit21, despite being able to build them directly.
After searching the setup.py, I found a comment that states:
#Couldn't get the Windows build to work. See
#https://luajit.org/install.html#windows
I am unsure if this means that the setup file cannot build on windows, or if it means that it is expecting one to build it themselves. Just in case that was true, I built with "msvcbuild.bat", and reran, but nothing had changed. After more searching, it does not appear that this should be the case, as there are references to msvcbuild in the setup file. I am now at a loss and would greatly appreciate some insight into what is going on. Fixing this issue would allow for LuaJit to be distributed in the auto-generated wheels for windows, much like it already is in Linux.
The text was updated successfully, but these errors were encountered: