Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error for PredicateBuilder? #149

Open
NetMage opened this issue Oct 11, 2021 · 3 comments
Open

Documentation error for PredicateBuilder? #149

NetMage opened this issue Oct 11, 2021 · 3 comments

Comments

@NetMage
Copy link

NetMage commented Oct 11, 2021

The documentation says that AsExpandable is needed when using PredicateBuilder and that Invoke is used with the original expression when adding an And or Or clause, but the output from LINQKit.Microsoft.EntityFrameworkCore v5.0.26 doesn't use Invoke and doesn't appear to need AsExpandable any more.

@lawhorkl
Copy link

lawhorkl commented Mar 9, 2023

I'm interested as well in the answer to this as the line in the documentation surprised me while I was reading it after using LinqKit for the last few years.

@TheConstructor
Copy link
Contributor

It would seem, that since #54 you no longer need AsExpandable or Expand for every predicate. There are however cases were you may benefit from using it, and if you use e.g. Invoke yourself or [Expandable] it is still needed, as the PredicateBuilder does not internally call Expand, but only not uses Invoke any longer.

@EdwardBlair
Copy link
Contributor

@StefH I have lost all context over this after 6 years. Is a documentation update sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants