Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the ability to pass in None for both get_column_plot and get_column_pair_plot #2343

Open
R-Palazzo opened this issue Jan 13, 2025 · 0 comments · May be fixed by #2344
Open

Support the ability to pass in None for both get_column_plot and get_column_pair_plot #2343

R-Palazzo opened this issue Jan 13, 2025 · 0 comments · May be fixed by #2344
Assignees
Labels
bug Something isn't working feature:evaluation Related to running metrics or visualizations
Milestone

Comments

@R-Palazzo
Copy link
Contributor

R-Palazzo commented Jan 13, 2025

Environment Details

  • SDV version: 1.17.3

Error Description

According to what can be done on SDMetrics I should be able to use the get_column_pair_plot or get_column_plot function to visualize just the real data or synthetic data (if I don't have access to one of the two).

Steps to reproduce

from sdv.datasets.demo import get_available_demos, download_demo
from sdv.evaluation.single_table import get_column_pair_plot

data, metadata = download_demo(
    modality='single_table',
    dataset_name='census_extended'
)


fig = get_column_pair_plot(
    real_data=data,
    synthetic_data=None,
    metadata=metadata,
    column_names=['age', 'occupation'],
    plot_type='heatmap',
)

This errors out.

Expectation

I expect a heatmap to be shown for just the real data (single heatmap square rather than a side-by-side comparison), and the title should be updated to just say Real Data for columns '<name>' and '<name>'

I also expect that this same functionality to work in the opposite case (where I have only synthetic data but not real data).

@R-Palazzo R-Palazzo added bug Something isn't working feature:evaluation Related to running metrics or visualizations labels Jan 13, 2025
@R-Palazzo R-Palazzo added this to the 1.17.4 milestone Jan 13, 2025
@R-Palazzo R-Palazzo self-assigned this Jan 13, 2025
@R-Palazzo R-Palazzo changed the title Unable to create a heatmap with only the real data Support the ability to pass in None for both get_column_plot and get_column_pair_plot Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature:evaluation Related to running metrics or visualizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant