addSourceMiddleware fails to register custom middleware for screen events

[mwoods-familiaris]

When using addSourceMiddleware, the middleware is only registered for certain event types. As such, whilst track and page events are successfully routed via custom registered middleware, the screen event type bypasses them entirely.

This appears to stem from the return for sourceMiddlewarePlugin which omits the screen event binding for the apply method, when it constructs the plugin object:

  return {
    name: `Source Middleware ${fn.name}`,
    type: 'before',
    version: '0.1.0',

    isLoaded: (): boolean => true,
    load: (ctx): Promise<Context> => Promise.resolve(ctx),

    track: apply,
    page: apply,
    identify: apply,
    alias: apply,
    group: apply,
  }

Is the omission of the screen binding here intentional?

[silesky]

Thanks @mwoods-familiaris, looking. Screen events aren't used very much in analytics.js (which supports them, but most people use page events), which is why this slipped through the cracks.

[mwoods-familiaris]

Thanks @silesky. On that subject, is the intention for screen to only be used in mobile apps? E.g. in a single page application style website, is it intended for page to be used to record all navigation (even when it may not be a full new page load), or does screen fit the bill for those "navigation without page reload" situations?

[silesky]

Thanks @silesky. On that subject, is the intention for screen to only be used in mobile apps? E.g. in a single page application style website, is it intended for page to be used to record all navigation (even when it may not be a full new page load), or does screen fit the bill for those "navigation without page reload" situations?

I think using a page event for any navigation related event is most common on web, even for SPAs -- particularly if routing changed at all.

Screen is typically mobile specific (e.g in the context of a webview with a hybrid mobile app)