Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to NPM failed #81

Open
fredericbarthelet opened this issue Aug 20, 2023 · 14 comments
Open

Publish to NPM failed #81

fredericbarthelet opened this issue Aug 20, 2023 · 14 comments

Comments

@fredericbarthelet
Copy link
Contributor

Github action handling publishing of @serverless/typescript package to NPM currently fails.
Last published version is 3.30.1 - versioning of this package follows serverless main package versions.

Failed job : https://github.com/serverless/typescript/actions/runs/5819791268/job/16047655020

I believe this could be due to changes made on serverless NPM team and currently used Github action secret NPM_TOKEN might not be valid anymore. Could someone from serverless team help here ?

@fredericbarthelet
Copy link
Contributor Author

@ac360 could you help on the aforementioned issue :) ?

@fcappi
Copy link

fcappi commented Sep 13, 2023

Any updates about this issue?

@guillaume-le-fur
Copy link

guillaume-le-fur commented Sep 20, 2023

Edit : My bad, I hadn't read your comment about the token, you can disregard my comment 😅

Hello @fredericbarthelet,

Apparently, npm can throw 404 when publishing if you are not logged in.

Are you sure the token you use when publishing is still valid? See here. Maybe your token has expired?

Ps : Thank you for you (amazing) work on this package 🙂

@herebebogans
Copy link

Any updates on this?

Node 20 lambda runtime has just been released and ppl will want type AwsLambdaRuntime updated from serverless.

@IdrissMahjoubi
Copy link

IdrissMahjoubi commented Nov 25, 2023

Any updates on this build issue ? I need to use the invokeMode config attribute

@fredericbarthelet
Copy link
Contributor Author

@ac360 could you help on this issue and update the NPM_TOKEN value with a valid one in this repository secrets ? Thanks a lot for your help :)

@fredericbarthelet
Copy link
Contributor Author

@austencollins could you help on this issue? If you can update the NPM_TOKEN value with a new valid one in this repository secrets, that'd be perfect!
Thanks

@Mmarzex
Copy link

Mmarzex commented Jan 8, 2025

@fredericbarthelet Token has been updated, sorry about that.

@fredericbarthelet
Copy link
Contributor Author

Great! Thanks @Mmarzex for your help! Could you run the workflow or give me back rights on this repo to run the workflow?

@Mmarzex
Copy link

Mmarzex commented Jan 8, 2025

@fredericbarthelet
Copy link
Contributor Author

@Mmarzex, I just updated a few actions on test and build definition workflows as well as stepping up node version.
I just opened a pull request with the changes: #93

Installing dependencies seem to go like a charm: https://github.com/fredericbarthelet/serverlesstypescript/actions/runs/12679397766/job/35339008893. However, I'm blocked at npx sls schema step as I don't have a valid license key. Can I suggest you had a key from Serverless team as a secret in this repo under name SERVERLESS_LICENSE_KEY ?

@RishikeshDarandale
Copy link

RishikeshDarandale commented Jan 9, 2025

@Mmarzex , Can you please merge #93 and add either SERVERLESS_ACCESS_KEY or SERVERLESS_LICENSE_KEY ?

@RishikeshDarandale
Copy link

@Mmarzex , can we please do this today?

@RishikeshDarandale
Copy link

Going ahead with patch-package functionality for using serverless v4 feature, until #93 and this gets merged.

  • Copy the file(index.d.ts) from feat: update the schema for serverless v4 #92 to node_modules/@serverless/typescript/index.d.ts
  • Install patch-package with npm i patch-package
  • Run npx patch-package @serverless/typescripts
  • Add "postinstall": "patch-package" to your scripts in package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants