Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates? #5

Open
wiverson opened this issue Apr 22, 2021 · 1 comment
Open

Updates? #5

wiverson opened this issue Apr 22, 2021 · 1 comment

Comments

@wiverson
Copy link

Hi - I found the project, super cool. Noticed you haven't put out updates in a while. I made a few modifications on a local branch, including refactoring it to work with Maven (would like to push a version out to Maven central). FWIW seems to run fine on Big Sur with this initialization:

        WebView webview = new WebView()
                .size(800, 600)
                .title("Test")
                .resizable(true)
                .url("https://theoryofgeek.com/")
                .addJavascriptCallback("callback", x ->
                {
                    System.out.println(x);
                });
        webview.show();

I'd like to make a few tweaks to the API as well, e.g. instead of using finalize in WebappJniExtractor switch to a try-with-resources instead. Also add a bunch of additional test cases and perhaps some GitHub Actions to verify everything works on macOS, Windows. Probably update to the latest version of the core lib as well.

Would you prefer I submit this stuff to your repo as PRs, or just fork and run with it, or...?

@shannah
Copy link
Owner

shannah commented Apr 23, 2021

Thanks. I'd like to put some more time into this, but just haven't been able to in quite a while. Those changes sound great! Please do a PR, and I'll pull them in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants