with_scope, operators and ruby 2.6

[sbidoul]

Hi,

It seems that with_scope keys containing an operator do not work with ruby 2.6.

As an example, the following syntax change makes them work again:

-      {% with_scope price.gt: {default: {discount: 0}}, "functions.in" => {id: product_functions } %}
+      {% with_scope "price.gt" => {default: {discount: 0}}, "functions.in" => {id: product_functions } %}

The symptom is that in places such as

locomotive-shopinvader/lib/shop_invader/services/elastic_service.rb

Line 139 in cef298f

conditions.each do |key, value|

keys has value "t" instead of the value the developer intended (such as function.in).

I'm not sure if this issue arises in locomotive-shopinvader or upstream in locomotive.

[sbidoul]

cc/ @lmignon

[sbidoul]

@sebastienbeau @rvalyi do you have any opinion on this issue?