-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting custom app registration ClientID via UI #105
Comments
I definitely can and will add custom app registration via the UI. I am working on the next version but i will make sure it's also in this version. I do have some questions if you don't mind, I have 0 way of knowing anything about my users other than data that comes from the Microsoft Store, and that's limited to very short cryptic crash logs, and number installs or launches.
|
Sure thing. I'd be happy to help with testing if needed.
|
@cricketthomas I was thinking about this issue along with #107 and I wonder if both issues would be resolved by acting as a user instead of an app registration. That would at least be preferable at my company. |
The app registration is actually required for user impersonation. The app has no rights at all, it's performing all actions as the signed in user, if the user can't do it, the app can't do it. #107 is mainly around some assumptions I made when building the application which will have to be fixed, since it was a bad approach to assume most users in the tenant have global reader over subscriptions and RGs. The app just needs to be installed in your tenant so you can sign into it with your from your domain, I have no control over anything other than registering in my own tenant as a multi-tenanted application. Also, since your firm has blocked the Microsoft store, would an MSIX package solve your issue so you can install it (outside of the store)? I'm on vacation right now so I can't actually code anything right now, but when I get back I'll work on getting these issues taken care of. |
Yes, an MSIX would be very helpful. I guess that explanation makes me wonder how the old MS Keyvault app made things work. Were they using some all-powerful app reg specially provision by MS? |
They offer multiple methods. One uses a vault.json settings file that lets you add any vault with a client secret. The other is their internal app. I assume they have it set up so this internal app is automatically trusted, but I haven’t been able to download or compile the code to confirm. With that in mind, I’m going to focus on which approach might be more beneficial for companies. Setting your own app/client ID, or simply adding vaults via service principals in a JSON file the way they’ve done. Which do you think is best? |
My use of the old app was with the VaultAccessUserInteractive mode. Personally, I'd rather not have to manage a raw json file that's external to the app UI. Could you provide an option to get the user token with Microsoft's first party appId, like here? |
Can you add a config option to set the ClientID instead of requiring a custom build of the exe?
The text was updated successfully, but these errors were encountered: