Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outer Border: should it be on #input instead of outer element? #17

Open
sidewayss opened this issue Nov 26, 2024 · 0 comments
Open

Outer Border: should it be on #input instead of outer element? #17

sidewayss opened this issue Nov 26, 2024 · 0 comments
Labels
question Further information is requested

Comments

@sidewayss
Copy link
Owner

sidewayss commented Nov 26, 2024

Of course a different template can do it differently. I don't believe the code touches on this (better verify that).

Currently the border is applied to the element itself. This has advantages and makes semantic sense in that it encapsulates the entire element. On the other hand it comes with side-effects, both positive and negative, especially as it relates to the mouse:

  1. It allows you (using only the width of the border, which I set at 1px) to hover and click on the outer element without focusing #input or the buttons.
  2. Mousing from outside the element into a button: #hover(), the outer element handler, fires first. This can cause the image to flicker on idle before displaying the button. I don't know which would fire first without the border on the outer element...
  3. ...I have a vague memory of more side-effects.

The border could be on #input instead, as the size is the same (the buttons overlap #input). But I think that would come with its own set of side-effects.

@sidewayss sidewayss added the question Further information is requested label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant