Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Docs: gem 'signalfx-rails-instrumentation' is Ruby syntax, not Bash #51

Open
pboling opened this issue May 19, 2022 · 0 comments · May be fixed by #52
Open

Docs: gem 'signalfx-rails-instrumentation' is Ruby syntax, not Bash #51

pboling opened this issue May 19, 2022 · 0 comments · May be fixed by #52

Comments

@pboling
Copy link

pboling commented May 19, 2022

The following bit of the README is wrong:

Add each applicable instrumentation to your application's Gemfile. For
example, this is how you add Rails and Redis:

$ gem 'signalfx-rails-instrumentation'
$ gem 'signalfx-redis-instrumentation'

That is mixing up Ruby with Bash.

Correct Bash: this is how you add Rails and Redis:

$ bundle add signalfx-rails-instrumentation
$ bundle add signalfx-redis-instrumentation

Correct Ruby in Gemfile:

gem 'signalfx-rails-instrumentation'
gem 'signalfx-redis-instrumentation'

Have to pick one, the other, or both, but they can't be merged!

@pboling pboling linked a pull request May 19, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant