Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when the service doesn't have a protocol trait applied #2452

Open
jjant opened this issue Mar 13, 2023 · 0 comments · May be fixed by #3551
Open

Improve error message when the service doesn't have a protocol trait applied #2452

jjant opened this issue Mar 13, 2023 · 0 comments · May be fixed by #3551
Labels
good first issue Good for newcomers low-priority

Comments

@jjant
Copy link
Contributor

jjant commented Mar 13, 2023

Currently, if you don't specify a protocol trait in your service, you get an error like this:

Projection test-service failed: software.amazon.smithy.codegen.core.CodegenException: No matching protocol — service offers: []. We offer: [aws.protocols#restJson1, aws.protocols#restXml, aws.protocols#awsJson1_0, aws.protocols#awsJson1_1]

We should clarify that you should probably put one of those traits in your model. And also improve formatting (add some line breaks).
@jjant jjant added good first issue Good for newcomers low-priority labels Mar 13, 2023
djedward added a commit to djedward/smithy-rs that referenced this issue Apr 3, 2024
@djedward
Improve error when service is missing protocol
66445a9 
resolves smithy-lang#2452
----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@djedward djedward linked a pull request Apr 3, 2024 that will close this issue
Open
2 tasks
djedward added a commit to djedward/smithy-rs that referenced this issue Apr 3, 2024
@djedward
Improve error when service is missing protocol
9343a39 
resolves smithy-lang#2452
----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
djedward added a commit to djedward/smithy-rs that referenced this issue Apr 3, 2024
@djedward
Improve error when service is missing protocol
9b3b33a 
resolves smithy-lang#2452
----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
djedward added a commit to djedward/smithy-rs that referenced this issue Apr 3, 2024
@djedward
Improve error when service is missing protocol
c548822 
resolves smithy-lang#2452
----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error when service is missing protocol djedward/smithy-rs
1 participant
@jjant