Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

300 USD Bug: Volume is considering volume through add and remove liquidity, should only be swap volume #79

Open
esteblock opened this issue Oct 23, 2024 · 28 comments
Assignees
Labels
good first issue Good for newcomers ODHack9

Comments

@esteblock
Copy link
Member

esteblock commented Oct 23, 2024

Budget: 300 USD

Guidelines:

Join Soroswap Discord: https://discord.com/invite/yXFaku4w9u
Join #onlydust channel
Discuss there if you wanna be assigned
Continue the discussion there
@suhas-sensei
Copy link

i want to tackle this, having experience in this regard.
i will volume calculation from addLiquidity and removeLiquidity functions and keep volume tracking only in swap function, ensuring it captures only the actual trading volume. then i will update the volume metric to track only the value of tokens being swapped directly through the swap function.
now since not much description is provided, im unsure whether to track volume in terms of token0 or token1's value, or if it needs to be converted to a standard unit (like USD) for consistency across different pairs.

@martinvibes
Copy link

Can I tackle this one?
kindly assign :)

@NueloSE
Copy link

NueloSE commented Oct 29, 2024

Is this issue still available? I would like to contribute to it kindly assign me

@Jemiiah
Copy link

Jemiiah commented Oct 29, 2024

@esteblock pls could I be assigned this issue here's my onlydust profile : https://github.com/Jemiiah
ETA : 48 hours

@tasneemtoolba
Copy link

I’d love to work on this task.

@PoulavBhowmick03
Copy link

May I take this issue on?
I'm Poulav Bhowmick, a Starknet Wolf. My projects can be viewed on my GitHub Profile and OnlyDust Profile. Plus I´m active member of Starknet, Ethereum, Stellar ecosystem.

I would go through the code, look at the bug and try to fix this

ETA - 1 day

@ikemHood
Copy link

Hey @esteblock, can I jump on this,

I would figure where the volume logic was written and what is not acting as expected, the. Rewrite that to fix the volume.

ETA: 24hrs

@aniruddhaaps
Copy link

I'm a javascript dev, a new comer here. I want to take the issue and solve it.

@0xdevcollins
Copy link

Can I contribute to this one?

@Kaminar-i
Copy link

Is it okay if I take this?

@Benjtalkshow
Copy link

Hey @esteblock
I can easily fix this issue. It will take me 24hrs max. Thanks.

@sigmadawg
Copy link

im a newbie contributor, i'd be grateful if you'd give me the opportunity to work in this.

@Bosun-Josh121
Copy link

Bosun-Josh121 commented Oct 30, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

software engineering background, backend & smart contract dev(https://app.onlydust.com/u/Josh-121) looking to make first contribution on this project

How I plan on tackling this issue

  1. Filter Transaction Types: Update the volume calculation logic to distinguish between swap transactions and add/remove liquidity events. The function will filter for swap events exclusively.
  2. Refactor Existing Code: Adjust any related functions and data models to ensure only swap transactions are counted toward the volume metric, leaving add/remove liquidity events untouched.
    work on feedback & recommendation ensuring contact. Can deliver within a day

@suhas-sensei
Copy link

@esteblock thank you for assigning me

@esteblock
Copy link
Member Author

@esteblock thank you for assigning me
Hello @suhas-sensei
I have not seen any draft PR. Do you have something?
If not, I will assign other dev.
If you have any question please reach on Discord https://discord.com/invite/G8c98rhfqw

@suhas-sensei
Copy link

@esteblock yes I tried reaching you out but telegram was off, sending a draft i 6hrs

@suhas-sensei suhas-sensei mentioned this issue Nov 1, 2024
3 tasks
@esteblock
Copy link
Member Author

@esteblock yes I tried reaching you out but telegram was off, sending a draft i 6hrs

Hello Sorry, We are only available on Discord. I will check your PR now

@esteblock
Copy link
Member Author

There is an error in your PR, please fix @suhas-sensei

@esteblock
Copy link
Member Author

Hello @suhas-sensei ?

@esteblock
Copy link
Member Author

Hello everybody. If you wanna be asigned please reach us on Discord https://discord.com/invite/G8c98rhfqw

@Benjtalkshow
Copy link

Hello @esteblock
can i work on this. i have solved a similar challenge before.

@mimisavage
Copy link

Hi @esteblock i reached out on discord, can I be assigned this issue, I can can handle the task

@Michaelkingsdev
Copy link

Can this be assigned to me?

@esteblock esteblock changed the title Bug: Volume is considering volume through add and remove liquidity, should only be swap volume 300 USD Bug: Volume is considering volume through add and remove liquidity, should only be swap volume Nov 13, 2024
@esteblock esteblock added the good first issue Good for newcomers label Nov 13, 2024
@0xdevcollins
Copy link

Hello @esteblock can i work on this. I will ensure create a draft PR today

@aniruddhaaps
Copy link

gm @esteblock i am a beginner in open-source, recently worked on some issues in OD, and would like to contribute here.

@ikemHood
Copy link

Hello @esteblock I sent a message in the discord channel

@wheval
Copy link
Contributor

wheval commented Nov 14, 2024

Hello @esteblock, I reached out on Discord, can I be assigned this issue? Will create a draft PR today

@PrincesoDan
Copy link

I'd like to take this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ODHack9
Projects
None yet
Development

No branches or pull requests