Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document URI's not formatted correctly in RDF/XML format #138

Open
goneall opened this issue Nov 2, 2023 · 11 comments
Open

Document URI's not formatted correctly in RDF/XML format #138

goneall opened this issue Nov 2, 2023 · 11 comments

Comments

@goneall
Copy link
Member

goneall commented Nov 2, 2023

For example, the generated document namespace for java-spdx-tagvalue-store version 1.6:

http://spdx.org/documents/java-spdx-tagvalue-store-%7B$version%7D

It should be:

http://spdx.org/documents/java-spdx-tagvalue-store-1.1.7
@goneall goneall changed the title External document references do not format the version properly Document URI's not formatted correctly in RDF/XML format Nov 5, 2023
@goneall
Copy link
Member Author

goneall commented Nov 5, 2023

Note: the JSON format works fine

@AniketNS
Copy link

AniketNS commented Nov 9, 2023

Hey @goneall, Assign this issue to me. I'd like to work on this.

@goneall
Copy link
Member Author

goneall commented Nov 12, 2023

Hey @goneall, Assign this issue to me. I'd like to work on this.

Hi @AniketNS , welcome to the project! Please feel free to take this issue. I'm currently traveling with limited access for the next 2 weeks. Once I'm back online I'll be able to assign the issue and answer any question you may have.

@AniketNS
Copy link

Sure @goneall, Thanks.

@AniketNS
Copy link

Hey @goneall, Am I supposed to make changes in the pom.xml file? Correct me If I'm wrong.

@goneall
Copy link
Member Author

goneall commented Nov 16, 2023

Hey @goneall, Am I supposed to make changes in the pom.xml file? Correct me If I'm wrong.

@AniketNS there's more to it. I can give you some background once I'm back from travels in about a week.

@AniketNS
Copy link

Sure @goneall.

@goneall
Copy link
Member Author

goneall commented Dec 14, 2023

@AniketNS - the fix will be in the code - around here: https://github.com/spdx/spdx-maven-plugin/blob/4bfcec8c9cac2ff667a190cf27929b9f1e99657b/src/main/java/org/spdx/maven/CreateSpdxMojo.java#L610C13-L610C13

or here:

spdxDoc = SpdxModelFactory.createSpdxDocument( modelStore, spdxDocumentNamespace.toString(), copyManager );

I'd like to get this into a release I'm preparing - so let me know if you think you can get to this over the next couple of days, otherwise I'll take a stab at a fix.

@goneall
Copy link
Member Author

goneall commented Dec 14, 2023

I did a bit more looking and this is a bit of a challenging issue. Not sure why it only happens in the RDF XML format. Since it is only impacting RDF/XML and JSON is a much more popular format, I'm going to go ahead and postpone fixing this until the next release.

@AniketNS feel free to try and tackle this, but you may also find it quite a challenge to isolate the issue. Let me know if you're interested in looking into it.

@AniketNS
Copy link

Sorry @goneall, I don't think I can solve this issue. To my knowledge, I don't even know what is the problem here. So feel free to assign this issue to someone else.

@goneall
Copy link
Member Author

goneall commented Dec 18, 2023

Thanks @AniketNS for the reply.

@goneall goneall closed this as completed Dec 18, 2023
@goneall goneall reopened this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants