You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In seasonal_onset.R there is an option to get results for the current season only. However, the analysis is first applied to all data and then the previous seasons are filtered out afterwards.
Suggestion: When results should only be returned for the current season then the input should be filtered at the top so that only the needed analysis is performed. One way could be to filter data to include the current season plus the k-1 last observations from the previous season.
The text was updated successfully, but these errors were encountered:
Focus on issues #47 to #50
### Checklist
* [ ] The PR passes all local unit tests
* [ ] I have documented any new features introduced
* [ ] If the PR adds a new feature, please add an entry in `NEWS.md`
* [ ] A reviewer is assigned to this PR
Focus on issues #47 to #50
### Checklist
* [ ] The PR passes all local unit tests
* [ ] I have documented any new features introduced
* [ ] If the PR adds a new feature, please add an entry in `NEWS.md`
* [ ] A reviewer is assigned to this PR
In seasonal_onset.R there is an option to get results for the current season only. However, the analysis is first applied to all data and then the previous seasons are filtered out afterwards.
Suggestion: When results should only be returned for the current season then the input should be filtered at the top so that only the needed analysis is performed. One way could be to filter data to include the current season plus the k-1 last observations from the previous season.
The text was updated successfully, but these errors were encountered: