Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for selecting a solution via UI #2

Open
razzmatazz opened this issue Mar 5, 2023 · 4 comments
Open

Support for selecting a solution via UI #2

razzmatazz opened this issue Mar 5, 2023 · 4 comments

Comments

@razzmatazz
Copy link

razzmatazz commented Mar 5, 2023

Continuation of #1

There is an alternative version of this extension that has a different approach to installing csharp-ls (it installs it as a nuget package locally and the version is pinned.) I like your approach better though (to rely on globally-installed csharp-ls.) Each has its prons and cons.

One thing that https://github.com/vytautassurvila/vscode-csharp-ls has beautifully implemented is selection of a solution file, in case there are several found.

Not sure if you're willing to port that, but it is useful and very nicely implemented on @vytautassurvila's version

@statiolake
Copy link
Owner

statiolake commented Mar 5, 2023

Thank you, but I'm not planning to massively improve this extension further. I'm very glad to hear that there is another extension supporting csharp-ls. I was not aware that there was another extension. If I had been aware of that extension earlier, I might not have created this extension...

Personally all I needed is to use csharp-ls with VSCode, at least completions and jump to definition. As a full-featured C# development environment, OmniSharp is usually a better choice. For me, this extension is just for projects including COM references -- OmniSharp can't handle this (dotnet/vscode-csharp#3766) but csharp-ls at least works. Other than that, I won't recommend using this extension as it has many bugs, such as Code Lens not working correctly. I'll add those things to README.md later.

Again, thanks for your interest!

@razzmatazz
Copy link
Author

Thanks for the explanation. This is a side-hustle for me as well!

Now ok, so maybe.. can I clone your repo, and publish another vscode-csharp-ls on my name as well, where I can integrate other changes, from @vytautassurvila too?

There will be two vscode-csharp-ls items on the marketplace but maybe thats not bad.

@NCLnclNCL
Copy link

Thanks for the explanation. This is a side-hustle for me as well!

Now ok, so maybe.. can I clone your repo, and publish another vscode-csharp-ls on my name as well, where I can integrate other changes, from @vytautassurvila too?

There will be two vscode-csharp-ls items on the marketplace but maybe thats not bad.

Yes bro

@statiolake
Copy link
Owner

So sorry, I've forgotten about this issue.

can I clone your repo, and publish another vscode-csharp-ls on my name as well

Of course!
I released it under the MIT license so that people who want to use csharp-ls with VSCode can use this code as a base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants