Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate a restructuring of this extension that changes the code from stream-based to effect-based #40

Open
stechyo opened this issue Jan 26, 2024 · 2 comments
Labels
enhancement New improvement to an existing feature

Comments

@stechyo
Copy link
Owner

stechyo commented Jan 26, 2024

As of 0.1.0, this extension relies on replacing user-provided audio streams with SteamAudioStreams that hijack the raw audio as it is is being mixed and apply SteamAudio effects over it. This works well for basic use cases, but it can cause jank and issues (#39, #29, #25, #24).

I'm opening this ticket as a reminder to investigate the possiblity of using audio effects to replace SteamAudioStream. If I can access raw audio as it's being mixed this way, I might be able to heavily reduce bugs (I might be trading advanced stream use-case bugs for advanced audio effect bugs, but I think I prefer it that way). This may also fix #18 (that would honestly be the best part).

@stechyo stechyo added the enhancement New improvement to an existing feature label Jan 26, 2024
@MasterDingo
Copy link

Is there any progress? Maybe, some help is needed?

@stechyo
Copy link
Owner Author

stechyo commented Aug 12, 2024

I'm not sure how feasible this way of doing things is. From what I've seen in the Godot source code, it would be a lot more complicated to extend audio effects than the current way this extension works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants