Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the Review and Response types #1782

Open
aristidesstaffieri opened this issue Jan 13, 2025 · 0 comments
Open

Split the Review and Response types #1782

aristidesstaffieri opened this issue Jan 13, 2025 · 0 comments

Comments

@aristidesstaffieri
Copy link
Contributor

aristidesstaffieri commented Jan 13, 2025

Right now in our service layer - we use an interface called Response on both the request and response sides of the background interaction workflow. This means that the interface incorrectly represents 2 different interfaces as 1. We should split Request to be only background script request parameters and Response to only be used for background script responses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant