Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: get rid of modifySorobanNetworkConfig in favor of upgradeSorobanNetworkConfig #4608

Closed
marta-lokhova opened this issue Jan 7, 2025 · 1 comment
Closed

tests: get rid of modifySorobanNetworkConfig in favor of upgradeSorobanNetworkConfig #4608

marta-lokhova opened this issue Jan 7, 2025 · 1 comment
Labels
bug

Comments

@marta-lokhova
Copy link
Contributor

We should remove all occurrences of modifySorobanNetworkConfig: it's quite error-prone and confusing, because it adds a new batch to the bucketlist and updates snapshot twice, causing all kind of cryptic failures that are hard to debug (see #4602 (comment) and #4583 (comment)). We should use upgradeSorobanNetworkConfig instead which properly performs an upgrade via ledger close. Note that with this change we should be able to remove SorobanNetworkConfig::writeAllSettings completely.
@marta-lokhova
Copy link
Contributor Author

dupe of #4605, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marta-lokhova