Remove TESTDB_BUCKET_DB_PERSISTENT_POSTGRES Test Mode
#4614
Assignees
Labels
Comments
|
I'll do this as part of #4625 |
bboston7
added a commit
to bboston7/stellar-core
that referenced
this issue
Jan 17, 2025
Resolves stellar#4625 and stellar#4614. This change fixes the tests in the `--disable-postgres` build by disabling parallel ledger close tests when postgres is disabled. This is necessary because parallel ledger close requires postgres. As part of this, I also removed the `TESTDB_BUCKET_DB_PERSISTENT_POSTGRES` test mode, as it's made redundant by the `TESTDB_POSTGRESQL` mode.
6 tasks
bboston7
added a commit
to bboston7/stellar-core
that referenced
this issue
Jan 17, 2025
Resolves stellar#4625 and stellar#4614. This change fixes the tests in the `--disable-postgres` build by disabling parallel ledger close tests when postgres is disabled. This is necessary because parallel ledger close requires postgres. As part of this, I also removed the `TESTDB_BUCKET_DB_PERSISTENT_POSTGRES` test mode, as it's made redundant by the `TESTDB_POSTGRESQL` mode.
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 17, 2025
Resolves #4625 and #4614. This change fixes the tests in the `--disable-postgres` build by disabling parallel ledger close tests when postgres is disabled. This is necessary because parallel ledger close requires postgres. As part of this, I also removed the `TESTDB_BUCKET_DB_PERSISTENT_POSTGRES` test mode, as it's made redundant by the `TESTDB_POSTGRESQL` mode. # Checklist - [x] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [x] Rebased on top of master (no merge commits) - [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [x] Compiles - [x] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should remove
TESTDB_BUCKET_DB_PERSISTENT_POSTGREStesting mode since it's identical in function toTESTDB_POSTGRESQL.The text was updated successfully, but these errors were encountered: