Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”€ Path payments within SDEX #944

Closed
JFWooten4 opened this issue Aug 26, 2024 · 3 comments
Closed

πŸ”€ Path payments within SDEX #944

JFWooten4 opened this issue Aug 26, 2024 · 3 comments

Comments

@JFWooten4
Copy link
Contributor

What problem does your feature solve?

Path payments are presently specified thinly, not accounting for material details integrated into the protocol.

Moreover, the existing documentation has no code examples. πŸ‘©β€πŸ’»

Lastly, it doesn't explain the hop limit.

What would you like to see? πŸ“

In consortium with #763, I propose moving path payments under the SDEX family of documentation.

At least today, path payments are primarily used for arbitrage trading over transfers.

Accordingly, it makes sense to move the op to documentation about liquidity. β™’

What alternatives are there?

We could leave path payments under transactions-specialized and improve the documentation.

This could look like new figures explaining path payments, codified demos, and new cross-referencing.

These additions would chiefly point the user to the SDEX sections which fundamentally power path payments. πŸ’±

@JFWooten4
Copy link
Contributor Author

This should really get integrated into a more organized SDEX section:

SDEX
β”œβ”€β”€ Liquidity
β”‚   β”œβ”€β”€ Generalized Liquidity
β”‚   β”‚   β”œβ”€β”€ Cross-Border Asset Markets
β”‚   β”‚   └── Multi-Currency Liquidity
β”‚   └── Market Depth
β”œβ”€β”€ Order Book
β”‚   β”œβ”€β”€ Bids
β”‚   └── Asks
β”œβ”€β”€ AMMs (Automated Market Makers)
β”‚   β”œβ”€β”€ Constant Product AMMs
β”‚   └── Pool Shares
β”œβ”€β”€ Path Payments
β”‚   β”œβ”€β”€ Source Asset
β”‚   └── Destination Asset
└── Soroban (Smart Contracts)
    β”œβ”€β”€ Trade Matching
    └── Liquidity Program Execution

@JFWooten4
Copy link
Contributor Author

The path payments page should also have a section specifically implicating the custody permissions required (and not so for hop assets) re issuing trustlines and account multisig.

@briwylde08
Copy link
Contributor

Adding to SDEX idea in ideas spreadsheet rather than keeping in docs issues.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Dev Docs Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants