Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children container inherit parents random color #399

Open
qazip opened this issue Apr 23, 2020 · 8 comments · May be fixed by #624
Open

Children container inherit parents random color #399

qazip opened this issue Apr 23, 2020 · 8 comments · May be fixed by #624

Comments

@qazip
Copy link

qazip commented Apr 23, 2020

It would be nice to have a different color of each different container. In this way, TC would also work as some sort of "tab organizer" and it would be easy to see which tabs belong to a particular container/group.

@qazip
Copy link
Author

qazip commented Apr 23, 2020

Ah I see, M-A-C. What's your opinion on using HAU instead? I've tried JKAY but it didn't quite do what I wanted.

Edit: If it wasn't obvious, I have no idea what M-A-C is. It's good practice to spell the word at least once before abreviating it.

@crssi
Copy link

crssi commented Apr 23, 2020

There is "Random Container Color" in the settings... or what do you mean?
What is HAU and JKAY?

@stoically
Copy link
Owner

stoically commented Apr 23, 2020

@qazip

As mentioned by @crssi there's a "random container" color option in the preferences. That randomly assigns one of the container colors provided by Firefox (can't add custom new ones) when new TCs are created. Managing colors wouldn't make much sense for temporary containers, since they're expected to get deleted, which would make manually managing colors not really feasible.

MAC is Multi-Account Containers which lets you manage permanent containers, including changing their colors. Could also change the color of containers in general directly in Firefox by navigating to about:preferences#containers.

@geeknik

IMHO, TC is bloated enough and M-A-C already provides this functionality.

How would you say TC is bloated?

@qazip
Copy link
Author

qazip commented Apr 23, 2020

With random colors a "children container" may have a different color than its "parent" container, right?

I just recently stopped using Tree Style Tab (TST (see geeknik? this is how you do it)) and I would like to find another way of visualizing tabs. I thought that TC could do it.

Basically, say you're logged in on reddit on a container and you click on a few links, opening all of them in the same container. Now you also have a different reddit tab, not logged in, in a different container. This, by default, is very confusing to me (having recently just come from TST). In which tabs are you logged in? In which ones are you not? With what I suggest, in this case, you would have 2 colors, one for the first group of reddit tabs and one for the second reddit tab. This would make it very easy to distinguish between them.

Having said that, if you don't think this is a handy feature, please close the issue. Regardless, thank you for this awesome extension!

@crssi
Copy link

crssi commented Apr 23, 2020

With random colors a "children container" may have a different color than its "parent" container, right?

It might, but not the way I am using it. See #140 (comment) and the next post #140 (comment)

And I have excluded Black color which I am using only for permanent containers, as @stoically mentioned over about:preferences#containers.

Cheers

@stoically
Copy link
Owner

@qazip

With random colors a "children container" may have a different color than its "parent" container, right?

If the children is created due to isolation, its a completely new temporary container with a new color (and new name/number), yes.

In which tabs are you logged in? In which ones are you not?

You're never logged-in in new temporary containers - as they're a new container with fresh storage.

I like the idea of having an preference that lets children container inherit the parent color. Not sure if it makes sense if storage is divided though? But I can see it making sense from the "TST hierarchy perspective".


(TST (see geeknik? this is how you do it))

While I do agree that trying to give context is important, I also think it's important to stay polite. So I'd appreciate if "politely giving pointers" gets priority over "making jokes about how someone is doing something wrong" in this repository.

@qazip
Copy link
Author

qazip commented Apr 23, 2020

I like the idea of having an preference that lets children container inherit the parent color. Not sure if it makes sense if storage is divided though? But I can see it making sense from the "TST hierarchy perspective".

Yes, this is exactly what I mean!

@stoically stoically changed the title Different colors for different containers Children container inherit the parents random color Apr 24, 2020
@stoically stoically changed the title Children container inherit the parents random color Children container inherit parents random color Apr 24, 2020
@MahdiNazemi
Copy link

Would it be possible to add an option to allow an isolated container to inherit its color (and possibly shape) from the container it is isolated from when colors are assigned randomly?

This helps to visually categorize containers based on subject, especially if the list of colors is shuffled once and later used in a round-robin fashion. Such ordering of colors is preferable over a random assignment of colors, where two newly created containers may be assigned the same color.

P.S. I was not sure whether I had to request this feature here or create a new issue. A few comments in this thread are off-topic. @stoically, please let me know if creating a new issue helps track this feature request more effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants